This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_distutils should honor PYTHONDONTWRITEBYTECODE
Type: behavior Stage: resolved
Components: Distutils, Distutils2, macOS, Tests Versions: Python 3.1, Python 3.2, Python 3.3, Python 2.7, 3rd party
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: eric.araujo Nosy List: donmez, eric.araujo, ned.deily, python-dev, tarek
Priority: normal Keywords:

Created on 2010-09-11 09:46 by donmez, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (11)
msg116084 - (view) Author: Ismail Donmez (donmez) * Date: 2010-09-11 09:46
Using py3k branch revision 84707, on Mac OSX 10.6, case-sensitive HFS+ filesystem.


======================================================================
FAIL: test_package_data (distutils.tests.test_build_py.BuildPyTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/cartman/Sources/py3k/Lib/distutils/tests/test_build_py.py", line 56, in test_package_data
    self.assertTrue("__init__.pyc" in files)
AssertionError: False is not True
msg116100 - (view) Author: Ismail Donmez (donmez) * Date: 2010-09-11 15:10
Btw I configure with;

./configure --with-wctype-functions --with-fpectl --with-wide-unicode --with-computed-gotos --enable-ipv6 --with-universal-archs=64-bit MACOSX_DEPLOYMENT_TARGET=10.6
msg116148 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2010-09-12 04:33
Thank you for the report.  Can you apply this change and paste the new, more useful output?

-    self.assertTrue("__init__.pyc" in files)
+    self.assertIn("__init__.pyc", files)
msg116157 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2010-09-12 09:02
I am not able to reproduce that failure running on 10.6 (case-sensitive HFS+) using your ./configure options and running the tests in the build directory (make test).  How are you running the tests?  Could there be a file or directory permissions issue?
msg116159 - (view) Author: Ismail Donmez (donmez) * Date: 2010-09-12 09:33
Problem is I set PYTHONDONTWRITEBYTECODE to 1, tests should disable this environmental variable before testing for *.pyc files. Closing as invalid.
msg116246 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2010-09-12 23:09
I noticed this bug in the tests of distutils2 and added it to my todo list some time ago.  Tests looking at pycs should take PYTHONDONTWRITEBYTECODE into account and be skipped instead of failing.  I’ll fix it.
msg137188 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2011-05-29 16:00
New changeset da7617248935 by Éric Araujo in branch '2.7':
Fix test_distutils when sys.dont_write_bytecode is true (#9831).
http://hg.python.org/cpython/rev/da7617248935
msg137190 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2011-05-29 16:14
New changeset 3d56e559ffc6 by Éric Araujo in branch '3.1':
Fix test_build_py when sys.dont_write_bytecode is true (#9831).
http://hg.python.org/cpython/rev/3d56e559ffc6

New changeset 1370dc2690a2 by Éric Araujo in branch '3.2':
Merge doc touch-ups and fixes for #9831 and #9223 from 3.1
http://hg.python.org/cpython/rev/1370dc2690a2

New changeset c5d6a384132d by Éric Araujo in branch 'default':
Merge touch-ups and fixes for #9831 (+port fix to packaging) and #9223 from 3.2
http://hg.python.org/cpython/rev/c5d6a384132d
msg137192 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2011-05-29 16:18
Now fixed, thanks for the report.
msg137193 - (view) Author: Ismail Donmez (donmez) * Date: 2011-05-29 16:19
Awesome, thank you!
msg147498 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2011-11-12 15:14
I now think the change I did was wrong.  See #12119.
History
Date User Action Args
2022-04-11 14:57:06adminsetgithub: 54040
2011-11-12 15:14:48eric.araujosetmessages: + msg147498
2011-05-29 16:19:44donmezsetmessages: + msg137193
2011-05-29 16:18:58eric.araujosetstatus: open -> closed
versions: + Python 3.3
messages: + msg137192

resolution: fixed
stage: resolved
2011-05-29 16:14:19python-devsetmessages: + msg137190
2011-05-29 16:00:14python-devsetnosy: + python-dev
messages: + msg137188
2010-11-22 00:47:12eric.araujosetresolution: accepted -> (no value)
title: test_distutils fails on MacOSX 10.6 -> test_distutils should honor PYTHONDONTWRITEBYTECODE
2010-09-29 23:43:28eric.araujosetversions: + 3rd party
2010-09-12 23:11:38michael.foordsetnosy: - michael.foord
2010-09-12 23:09:26eric.araujosetstatus: closed -> open

assignee: tarek -> eric.araujo
components: + Distutils2
versions: + Python 3.1, Python 2.7
nosy: donmez, tarek, ned.deily, eric.araujo, michael.foord
messages: + msg116246
resolution: not a bug -> accepted
2010-09-12 09:33:34donmezsetstatus: open -> closed
resolution: not a bug
messages: + msg116159
2010-09-12 09:02:39ned.deilysetmessages: + msg116157
2010-09-12 04:33:44eric.araujosetmessages: + msg116148
2010-09-11 15:28:34floxsetnosy: + eric.araujo, tarek, ned.deily, michael.foord

components: + Distutils, macOS
assignee: tarek
2010-09-11 15:10:12donmezsetmessages: + msg116100
2010-09-11 09:46:18donmezcreate