This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: tcl-8 vs tcl8
Type: behavior Stage: resolved
Components: Build, Windows Versions: Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: zach.ware Nosy List: eric.araujo, loewis, python-dev, stutzbach, zach.ware
Priority: normal Keywords: patch

Created on 2010-09-03 20:46 by stutzbach, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
tcl.patch stutzbach, 2010-09-03 20:46
Messages (6)
msg115504 - (view) Author: Daniel Stutzbach (stutzbach) (Python committer) Date: 2010-09-03 20:46
Tools/buildbot/external-common.bat creates tcl-8.5.2.1, but Tools/msi/msi.py looks for tcl8*.  Consequently, Tools/buildbot/buildmsi.py does not work on a fresh machine.

tk has the same problem.

I encountered this on the py3k branch but have not checked other branches.

Attached is a simple patch to Tools/msi/msi.py.
msg115573 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2010-09-04 14:26
This patch is incorrect. The naming of the directories as in msi.py is correct; the naming in Tools/buildbot is slightly inappropriate.

Tix relies on the specific directory names referred-to by msi.py, hence I use a different in my buildarea than Tools/buildbot.
msg217084 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2014-04-23 19:56
PCbuild/tix.vcxproj explicitly sets TCL_DIR and TK_DIR in the command line used to build Tix, using the paths used by the rest of the solution and the Tools/buildbot scripts; would the attached patch now be acceptable (for 3.5 only)?
msg217085 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2014-04-23 20:01
For 3.5, it's fine.
msg217087 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-04-23 20:38
New changeset 4ff37fbcd4e8 by Zachary Ware in branch 'default':
Issue #9765: Adjust where Tools/msi/msi.py looks for Tcl/Tk license terms.
http://hg.python.org/cpython/rev/4ff37fbcd4e8
msg217088 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2014-04-23 20:39
Done, thanks!
History
Date User Action Args
2022-04-11 14:57:06adminsetgithub: 53974
2014-04-23 20:39:32zach.waresetstatus: open -> closed
messages: + msg217088

assignee: zach.ware
resolution: fixed
stage: commit review -> resolved
2014-04-23 20:38:04python-devsetnosy: + python-dev
messages: + msg217087
2014-04-23 20:01:26loewissetmessages: + msg217085
stage: patch review -> commit review
2014-04-23 19:56:57zach.waresetversions: + Python 3.5, - Python 3.2
nosy: + zach.ware

messages: + msg217084

stage: needs patch -> patch review
2010-09-11 23:54:56eric.araujosetnosy: + eric.araujo
2010-09-04 14:26:05loewissetmessages: + msg115573
2010-09-03 20:46:15stutzbachcreate