Using Python 2.6.5, the module _socket is failing to build on OpenSolaris. The problem can be worked around with a hack, but I've not verified if the hack actually results in working code - but at least it compiles. See below. 

The problem seems to be that HAVE_NETPACKET_PACKET_H gets defined, despite the fact there is no file called netpacket.h

running build
running build_ext
building '_socket' extension
gcc -fPIC -fno-strict-aliasing -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I. -I/export/home/drkirkby/Python-2.6.5/./Include -I. -IInclude -I./Include -I/usr/local/include -I/export/home/drkirkby/Python-2.6.5/Include -I/export/home/drkirkby/Python-2.6.5 -c /export/home/drkirkby/Python-2.6.5/Modules/socketmodule.c -o build/temp.solaris-2.11-i86pc-2.6/export/home/drkirkby/Python-2.6.5/Modules/socketmodule.o
/export/home/drkirkby/Python-2.6.5/Modules/socketmodule.c: In function ‘makesockaddr’:
/export/home/drkirkby/Python-2.6.5/Modules/socketmodule.c:1107: error: ‘struct ifreq’ has no member named ‘ifr_ifindex’
/export/home/drkirkby/Python-2.6.5/Modules/socketmodule.c:1108: error: ‘SIOCGIFNAME’ undeclared (first use in this function)
/export/home/drkirkby/Python-2.6.5/Modules/socketmodule.c:1108: error: (Each undeclared identifier is reported only once
/export/home/drkirkby/Python-2.6.5/Modules/socketmodule.c:1108: error: for each function it appears in.)
/export/home/drkirkby/Python-2.6.5/Modules/socketmodule.c: In function ‘getsockaddrarg’:
/export/home/drkirkby/Python-2.6.5/Modules/socketmodule.c:1415: error: ‘SIOCGIFINDEX’ undeclared (first use in this function)
/export/home/drkirkby/Python-2.6.5/Modules/socketmodule.c:1427: error: ‘struct ifreq’ has no member named ‘ifr_ifindex’
/export/home/drkirkby/Python-2.6.5/Modules/socketmodule.c: In function ‘init_socket’:
/export/home/drkirkby/Python-2.6.5/Modules/socketmodule.c:4596: error: ‘PACKET_LOOPBACK’ undeclared (first use in this function)
/export/home/drkirkby/Python-2.6.5/Modules/socketmodule.c:4597: error: ‘PACKET_FASTROUTE’ undeclared (first use in this function)
building '_curses' extension
gcc -fPIC -fno-strict-aliasing -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I. -I/export/home/drkirkby/Python-2.6.5/./Include -I. -IInclude -I./Include -I/usr/local/include -I/export/home/drkirkby/Python-2.6.5/Include -I/export/home/drkirkby/Python-2.6.5 -c /export/home/drkirkby/Python-2.6.5/Modules/_cursesmodule.c -o build/temp.solaris-2.11-i86pc-2.6/export/home/drkirkby/Python-2.6.5/Modules/_cursesmodule.o
/export/home/drkirkby/Python-2.6.5/Modules/_cursesmodule.c: In function ‘PyCursesWindow_ChgAt’:
/export/home/drkirkby/Python-2.6.5/Modules/_cursesmodule.c:708: warning: implicit declaration of function ‘mvwchgat’
/export/home/drkirkby/Python-2.6.5/Modules/_cursesmodule.c:712: warning: implicit declaration of function ‘wchgat’
gcc -shared build/temp.solaris-2.11-i86pc-2.6/export/home/drkirkby/Python-2.6.5/Modules/_cursesmodule.o -L/usr/local/lib -lcurses -ltermcap -o build/lib.solaris-2.11-i86pc-2.6/_curses.so
*** WARNING: renaming "_curses" since importing it failed: ld.so.1: python: fatal: relocation error: file build/lib.solaris-2.11-i86pc-2.6/_curses.so: symbol mvwchgat: referenced symbol not found
building '_curses_panel' extension
gcc -fPIC -fno-strict-aliasing -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I. -I/export/home/drkirkby/Python-2.6.5/./Include -I. -IInclude -I./Include -I/usr/local/include -I/export/home/drkirkby/Python-2.6.5/Include -I/export/home/drkirkby/Python-2.6.5 -c /export/home/drkirkby/Python-2.6.5/Modules/_curses_panel.c -o build/temp.solaris-2.11-i86pc-2.6/export/home/drkirkby/Python-2.6.5/Modules/_curses_panel.o
gcc -shared build/temp.solaris-2.11-i86pc-2.6/export/home/drkirkby/Python-2.6.5/Modules/_curses_panel.o -L/usr/local/lib -lpanel -lcurses -ltermcap -o build/lib.solaris-2.11-i86pc-2.6/_curses_panel.so
*** WARNING: renaming "_curses_panel" since importing it failed: No module named _curses
building 'sunaudiodev' extension
gcc -fPIC -fno-strict-aliasing -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I. -I/export/home/drkirkby/Python-2.6.5/./Include -I. -IInclude -I.

A patch (which is a hack, rather than a real solution), is below. 

drkirkby@hawk:~/Python-2.6.5/Modules$ diff -U 10  socketmodule.c.orig socketmodule.c
--- socketmodule.c.orig	Sat May 29 14:58:17 2010
+++ socketmodule.c	Sat May 29 15:26:08 2010
@@ -1089,20 +1089,21 @@
 		}
 #endif
 
 		default:
 			PyErr_SetString(PyExc_ValueError,
 					"Unknown Bluetooth protocol");
 			return NULL;
 		}
 #endif
 
+#undef HAVE_NETPACKET_PACKET_H /* Hack to build on OpenSolaris x64 */
 #ifdef HAVE_NETPACKET_PACKET_H
 	case AF_PACKET:
 	{
 		struct sockaddr_ll *a = (struct sockaddr_ll *)addr;
 		char *ifname = "";
 		struct ifreq ifr;
 		/* need to look up interface name give index */
 		if (a->sll_ifindex) {
 			ifr.ifr_ifindex = a->sll_ifindex;
 			if (ioctl(sockfd, SIOCGIFNAME, &ifr) == 0)

Please verify that HAVE_NETPACKET_PACKET_H does indeed get defined, looking at pyconfig.h.

Please inspect config.log to find out why it does get defined.

I was obviously looking for the wrong file. ./pyconfig.h shows:

/* Define to 1 if you have the <netpacket/packet.h> header file. */
#define HAVE_NETPACKET_PACKET_H 1

the file does indeed exist

drkirkby@hawk:~$ find /usr/include -name packet.h
/usr/include/netpacket/packet.h

Two points I should have stated. 

1) http://www.lotuseyes.de/blog/error-installing-plone-on-opensolaris-using-the-unified-installer

has a discussion about this issue. It was related to someone trying to install "Plone" but the problem is a failure of _socket to build. I'm trying to build the port the Sage maths software to OpenSolaris, and hit the problem there. 

2) If a *serious* developer would like access to the OpenSolaris machine which shows this problem, I can give you a temporary account. Drop me a private email. Otherwise, you can install OpenSolaris on a virtual machine under VirtualBox, or I can do my best to debug it with some help from a developer. 


Dave

The AF_PACKET support was original meant for Linux. When Solaris now also supports that socket family, and with a similar interface, it might be interesting to port that support to Solaris.

If nobody volunteers, it might be easier to restrict this to Linux only; please try the attached patch.

Hi,

thank you for the patch. 

I hope you can keep Python building the same modules on Solaris as Linux, as that would be a real shame if it did not. This module is used in the Sage maths software. 

I had some difficulty applying your patch using the 'patch' command. 'patch' just kept rejecting the file. Finally I gave up and patched it manually. 

It did not completely solve the problem as PACKET_FASTROUTE and PACKET_LOOPBACK were undeclared too

building '_socket' extension
gcc -fPIC -fno-strict-aliasing -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I. -I/export/home/drkirkby/Python-2.6.5/./Include -I. -IInclude -I./Include -I/usr/local/incl
ude -I/export/home/drkirkby/Python-2.6.5/Include -I/export/home/drkirkby/Python-2.6.5 -c /export/home/drkirkby/Python-2.6.5/Modules/socketmodule.c -o build/temp.solaris-2.11-i
86pc-2.6/export/home/drkirkby/Python-2.6.5/Modules/socketmodule.o
/export/home/drkirkby/Python-2.6.5/Modules/socketmodule.c: In function ‘init_socket’:
/export/home/drkirkby/Python-2.6.5/Modules/socketmodule.c:4597: error: ‘PACKET_LOOPBACK’ undeclared (first use in this function)
/export/home/drkirkby/Python-2.6.5/Modules/socketmodule.c:4597: error: (Each undeclared identifier is reported only once
/export/home/drkirkby/Python-2.6.5/Modules/socketmodule.c:4597: error: for each function it appears in.)
/export/home/drkirkby/Python-2.6.5/Modules/socketmodule.c:4598: error: ‘PACKET_FASTROUTE’ undeclared (first use in this function)
building '_ssl' extension

However, I decided to alter the Modules/socketmodule.c further and finally _socket built. I don't however know how to test _socket, so I don't know if it working or not. (I'm not a python programmer - just about to start learning it). But using

drkirkby@hawk:~/Python-2.6.5$ ./python
Python 2.6.5 (r265:79063, May 29 2010, 21:17:44) 
[GCC 4.4.4] on sunos5
Type "help", "copyright", "credits" or "license" for more information.
>>> import _socket
>>> 

it would appear its not completely broken. 

BTW, for the record, the hardware is a Sun Ultra 27 (quad core Xeon) running OpenSolaris 06/2009 which has been updated to build 134. 

drkirkby@hawk:~$ cat /etc/release
                       OpenSolaris Development snv_134 X86
           Copyright 2010 Sun Microsystems, Inc.  All Rights Reserved.
                        Use is subject to license terms.
                             Assembled 01 March 2010

I've built Sage on Solaris 10 (on SPARC hardware), so I don't think this patch is needed on Solaris 10, though I've not checked on Solaris 10 using Intel/AMD hardware. 

Dave

I forget to say I had attached the patch 'socketmodule.c.patch' which allows _socket to build. (I know you can see that if you look, but I thought it useful to write it). 

I do have some other modules not building on OpenSolaris (_curses, _curses_panel, _tkinter & sunaudiodev) but I'll create separate tickets for those. All of those 4 modules are included in the Python 2.6.4 shipped as part of OpenSolaris, so they can be built. 

Dave

I'd made a mistake when manually applying your patch, although my mistake made no practical difference. I'm attaching a corrected patch, which has all the changes needed to get this to build on OpenSolaris. It basically only checks for things before trying to compile with them, so it should be safe (and desirable) on any platform. 

I've not checked this on OpenSolaris on the SPARC hardware, though the use of OpenSolaris on SPARC hardware is very rare I believe. I' 99% sure that _socket builds ok on Solaris 10 on SPARC without any changes from the 2.6.4 source (I've not tried with 2.6.5) 

Dave

Has anyone done anything about fixing this issue? The patch I attached appears to allow _socket to build on OpenSolaris and when I run the test suite, there is no failure of _socket. 

I've just downloaded the latest source code for the 3.1.2, 2.6.5 and Python-2.7rc2. All three have this problems, so it needs fixing. 

As far as I can ascertain, the patch socketmodule.c.patch solves it. 

Dave

> Has anyone done anything about fixing this issue?

AFAICT, nobody did.

Is there anything I can do to get someone to do something about it? I would have thought with a patch, it would not be hard for someone to fix.

> Is there anything I can do to get someone to do something about it? I
> would have thought with a patch, it would not be hard for someone to
> fix.

Sure. Unfortunately, the day has only 24 hours.

Hi Martin, 

I appreciate your point. But do you know if anyone has it on their TODO list? If not, is there anything I could do about it? I don't have commit access to the Python source code, but if there is anything else I can do I'd like to. 

This is a pretty serious bug, as it stops one running the self-tests. Although Python builds and 99% of it works with this bug, an attempt to run the self-tests exits fairly quickly, with no tests performed. So despite there being over 300 tests, note one of them gets run unless one works around this bug. 

Hence the implication is a lot more than the fact that one can't use _socket. 

Dave 

drkirkby@hawk:~/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src$ make test
running build
running build_ext
building '_socket' extension
gcc -fPIC -fno-strict-aliasing -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I. -I/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/./Include -I. -IInclude -I./Include -I/usr/local/include -I/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Include -I/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src -c /export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/socketmodule.c -o build/temp.solaris-2.11-i86pc-2.6/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/socketmodule.o
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/socketmodule.c: In function 'makesockaddr':
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/socketmodule.c:1103: error: 'struct ifreq' has no member named 'ifr_ifindex'
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/socketmodule.c:1104: error: 'SIOCGIFNAME' undeclared (first use in this function)
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/socketmodule.c:1104: error: (Each undeclared identifier is reported only once
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/socketmodule.c:1104: error: for each function it appears in.)
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/socketmodule.c: In function 'getsockaddrarg':
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/socketmodule.c:1411: error: 'SIOCGIFINDEX' undeclared (first use in this function)
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/socketmodule.c:1423: error: 'struct ifreq' has no member named 'ifr_ifindex'
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/socketmodule.c: In function 'init_socket':
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/socketmodule.c:4589: error: 'PACKET_LOOPBACK' undeclared (first use in this function)
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/socketmodule.c:4590: error: 'PACKET_FASTROUTE' undeclared (first use in this function)
building '_ssl' extension
gcc -fPIC -fno-strict-aliasing -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I. -I/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/./Include -I. -IInclude -I./Include -I/usr/local/include -I/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Include -I/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src -c /export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/_ssl.c -o build/temp.solaris-2.11-i86pc-2.6/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/_ssl.o
gcc -shared build/temp.solaris-2.11-i86pc-2.6/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/_ssl.o -L/usr/local/lib -lssl -lcrypto -o build/lib.solaris-2.11-i86pc-2.6/_ssl.so
*** WARNING: renaming "_ssl" since importing it failed: No module named _socket
building '_curses' extension
gcc -fPIC -fno-strict-aliasing -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I. -I/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/./Include -I. -IInclude -I./Include -I/usr/local/include -I/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Include -I/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src -c /export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/_cursesmodule.c -o build/temp.solaris-2.11-i86pc-2.6/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/_cursesmodule.o
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/_cursesmodule.c: In function 'PyCursesWindow_ChgAt':
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/_cursesmodule.c:708: warning: implicit declaration of function 'mvwchgat'
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/_cursesmodule.c:712: warning: implicit declaration of function 'wchgat'
gcc -shared build/temp.solaris-2.11-i86pc-2.6/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/_cursesmodule.o -L/usr/local/lib -lcurses -ltermcap -o build/lib.solaris-2.11-i86pc-2.6/_curses.so
*** WARNING: renaming "_curses" since importing it failed: ld.so.1: python: fatal: relocation error: file build/lib.solaris-2.11-i86pc-2.6/_curses.so: symbol mvwchgat: referenced symbol not found
building '_curses_panel' extension
gcc -fPIC -fno-strict-aliasing -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I. -I/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/./Include -I. -IInclude -I./Include -I/usr/local/include -I/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Include -I/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src -c /export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/_curses_panel.c -o build/temp.solaris-2.11-i86pc-2.6/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/_curses_panel.o
gcc -shared build/temp.solaris-2.11-i86pc-2.6/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/_curses_panel.o -L/usr/local/lib -lpanel -lcurses -ltermcap -o build/lib.solaris-2.11-i86pc-2.6/_curses_panel.so
*** WARNING: renaming "_curses_panel" since importing it failed: No module named _curses
building 'sunaudiodev' extension
gcc -fPIC -fno-strict-aliasing -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I. -I/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/./Include -I. -IInclude -I./Include -I/usr/local/include -I/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Include -I/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src -c /export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c -o build/temp.solaris-2.11-i86pc-2.6/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.o
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:20:25: error: sun/audioio.h: No such file or directory
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:36: error: expected specifier-qualifier-list before 'audio_info_t'
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c: In function 'sad_getinfo':
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:198: error: 'AUDIO_GETINFO' undeclared (first use in this function)
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:198: error: (Each undeclared identifier is reported only once
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:198: error: for each function it appears in.)
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:198: error: 'sadstatusobject' has no member named 'ai'
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c: In function 'sad_setinfo':
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:214: error: 'AUDIO_SETINFO' undeclared (first use in this function)
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:214: error: 'sadstatusobject' has no member named 'ai'
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c: In function 'sad_ibufcount':
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:225: error: 'audio_info_t' undeclared (first use in this function)
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:225: error: expected ';' before 'ai'
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:227: error: 'AUDIO_GETINFO' undeclared (first use in this function)
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:227: error: 'ai' undeclared (first use in this function)
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c: In function 'sad_obufcount':
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:237: error: 'audio_info_t' undeclared (first use in this function)
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:237: error: expected ';' before 'ai'
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:239: error: 'AUDIO_GETINFO' undeclared (first use in this function)
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:239: error: 'ai' undeclared (first use in this function)
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c: In function 'sad_drain':
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:253: error: 'AUDIO_DRAIN' undeclared (first use in this function)
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c: At top level:
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:348: error: expected specifier-qualifier-list before 'audio_info_t'
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:348: error: expected '}' before ')' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:348: error: expected ',' or ';' before ')' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:348: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:349: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:350: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:351: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:352: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:353: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:354: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:355: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:356: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:357: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:358: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:359: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:360: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:367: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:368: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:369: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:370: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:371: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:372: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:373: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:374: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:375: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:376: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:377: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:378: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:379: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:386: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:387: error: expected identifier or '(' before ',' token
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c: In function 'sads_getattr':
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:393: error: 'sadstatusobject' has no member named 'ai'
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c: In function 'sads_setattr':
/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/sunaudiodev.c:405: error: 'sadstatusobject' has no member named 'ai'
building '_tkinter' extension
gcc -fPIC -fno-strict-aliasing -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -DWITH_APPINIT=1 -I/usr/openwin/include -I. -I/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/./Include -I. -IInclude -I./Include -I/usr/local/include -I/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Include -I/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src -c /export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/_tkinter.c -o build/temp.solaris-2.11-i86pc-2.6/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/_tkinter.o
In file included from /export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/_tkinter.c:67:
/usr/include/tk.h:81:23: error: X11/Xlib.h: No such file or directory
In file included from /export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/_tkinter.c:67:
/usr/include/tk.h:557: error: expected declaration specifiers or '...' before 'Window'
/usr/include/tk.h:557: error: 'Window' declared as function returning a function
/usr/include/tk.h:560: error: expected declaration specifiers or '...' before 'XEvent'
/usr/include/tk.h:569: error: expected specifier-qualifier-list before 'Tk_ClassCreateProc'
/usr/include/tk.h:661: error: expected specifier-qualifier-list before 'Bool'
/usr/include/tk.h:677: error: expected specifier-qualifier-list before 'Bool'
/usr/include/tk.h:754: error: expected specifier-qualifier-list before 'Display'
/usr/include/tk.h:904: error: expected declaration specifiers or '...' before 'XPoint'
/usr/include/tk.h:1005: error: expected declaration specifiers or '...' before 'Display'
/usr/include/tk.h:1007: error: expected declaration specifiers or '...' before 'Display'
/usr/include/tk.h:1007: error: expected declaration specifiers or '...' before 'Drawable'
/usr/include/tk.h:1104: error: expected specifier-qualifier-list before 'XColor'
/usr/include/tk.h:1168: error: expected specifier-qualifier-list before 'GC'
/usr/include/tk.h:1209: error: expected declaration specifiers or '...' before 'Display'
/usr/include/tk.h:1209: error: expected declaration specifiers or '...' before 'Drawable'
/usr/include/tk.h:1212: error: expected declaration specifiers or '...' before 'Display'
/usr/include/tk.h:1417: error: expected declaration specifiers or '...' before 'Drawable'
/usr/include/tk.h:1534: error: expected declaration specifiers or '...' before 'XErrorEvent'
/usr/include/tk.h:1536: error: expected declaration specifiers or '...' before 'XEvent'
/usr/include/tk.h:1538: error: expected declaration specifiers or '...' before 'XEvent'
/usr/include/tk.h:1540: error: expected declaration specifiers or '...' before 'XEvent'
/usr/include/tk.h:1545: error: expected declaration specifiers or '...' before 'XEvent'
In file included from /usr/include/tk.h:1559,
                 from /export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Modules/_tkinter.c:67:
/usr/include/tkDecls.h:37: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
/usr/include/tkDecls.h:39: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Tk_3DBorderGC'
/usr/include/tkDecls.h:42: error: expected declaration specifiers or '...' before 'Drawable'
/usr/include/tkDecls.h:47: error: expected declaration specifiers or '...' before 'Drawable'
/usr/include/tkDecls.h:56: error: expected declaration specifiers or '...' before 'XEvent'
/usr/include/tkDecls.h:76: error: expected declaration specifiers or '...' before 'Pixmap'
/usr/include/tkDecls.h:80: error: expected declaration specifiers or '...' before 'XColor'
/usr/include/tkDecls.h:90: error: expected declaration specifiers or '...' before 'Pixmap'
/usr/include/tkDecls.h:95: error: expected declaration specifiers or '...' before 'GC'
/usr/include/tkDecls.h:114: error: expected declaration specifiers or '...' before 'XSetWindowAttributes'
/usr/include/tkDecls.h:122: error: expected declaration specifiers or '...' before 'Atom'
/usr/include/tkDecls.h:125: error: expected declaration specifiers or '...' before 'Atom'
/usr/include/tkDecls.h:125: error: expected declaration specifiers or '...' before 'Atom'
/usr/include/tkDecls.h:147: error: expected declaration specifiers or '...' before 'XWindowChanges'
/usr/include/tkDecls.h:167: error: expected ')' before '*' token
/usr/include/tkDecls.h:187: error: expected declaration specifiers or '...' before 'Atom'
/usr/include/tkDecls.h:187: error: expected declaration specifiers or '...' before 'Atom'
/usr/include/tkDecls.h:187: error: expected declaration specifiers or '...' before 'Atom'
/usr/include/tkDecls.h:232: error: expected declaration specifiers or '...' before 'Atom'
/usr/include/tkDecls.h:232: error: expected declaration specifiers or '...' before 'Atom'
/usr/include/tkDecls.h:242: error: expected declaration specifiers or '...' before 'Drawable'
/usr/include/tkDecls.h:242: error: expected declaration specifiers or '...' before 'XPoint'
/usr/include/tkDecls.h:247: error: expected declaration specifiers or '...' before 'Drawable'
/usr/include/tkDecls.h:252: error: expected ')' before '*' token
/usr/include/tkDecls.h:257: error: expected declaration specifiers or '...' before 'GC'
/usr/include/tkDecls.h:257: error: expected declaration specifiers or '...' before 'Drawable'
/usr/include/tkDecls.h:260: error: expected ')' before '*' token
/usr/include/tkDecls.h:265: error: expected declaration specifiers or '...' before 'Drawable'
/usr/include/tkDecls.h:265: error: expected declaration specifiers or '...' before 'XPoint'
/usr/include/tkDecls.h:270: error: expected declaration specifiers or '...' before 'Drawable'
/usr/include/tkDecls.h:278: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Tk_FontId'
/usr/include/tkDecls.h:282: error: expected ')' before '*' token
/usr/include/tkDecls.h:285: error: expected ')' before '*' token
/usr/include/tkDecls.h:287: error: expected ')' before '*' token
/usr/include/tkDecls.h:290: error: expected ')' before '*' token
/usr/include/tkDecls.h:295: error: expected ')' before '*' token
/usr/include/tkDecls.h:299: error: expected declaration specifiers or '...' before 'Display'
/usr/include/tkDecls.h:303: error: expected ')' before '*' token
/usr/include/tkDecls.h:309: error: expected ')' before '*' token
/usr/include/tkDecls.h:311: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Tk_GCForColor'
/usr/include/tkDecls.h:327: error: expected declaration specifiers or '...' before 'Atom'
/usr/include/tkDecls.h:334: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Tk_GetBitmap'
/usr/include/tkDecls.h:337: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Tk_GetBitmapFromData'
/usr/include/tkDecls.h:344: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
/usr/include/tkDecls.h:347: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
/usr/include/tkDecls.h:350: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Tk_GetColormap'
/usr/include/tkDecls.h:371: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Tk_GetGC'
/usr/include/tkDecls.h:401: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Tk_GetPixmap'
/usr/include/tkDecls.h:418: error: expected declaration specifiers or '...' before 'Atom'
/usr/include/tkDecls.h:418: error: expected declaration specifiers or '...' before 'Atom'
/usr/include/tkDecls.h:424: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
/usr/include/tkDecls.h:435: error: expected ')' before '*' token
/usr/include/tkDecls.h:437: error: expected ')' before '*' token
/usr/include/tkDecls.h:446: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Tk_InternAtom'
/usr/include/tkDecls.h:484: error: expected ')' before '*' token
/usr/include/tkDecls.h:489: error: expected ')' before '*' token
/usr/include/tkDecls.h:491: error: expected ')' before '*' token
/usr/include/tkDecls.h:509: error: expected declaration specifiers or '...' before 'Atom'
/usr/include/tkDecls.h:549: error: expected ')' before '*' token
/usr/include/tkDecls.h:552: error: expected ')' before '*' token
/usr/include/tkDecls.h:555: error: expected declaration specifiers or '...' before 'Drawable'
/usr/include/tkDecls.h:591: error: expected declaration specifiers or '...' before 'Pixmap'
/usr/include/tkDecls.h:600: error: expected declaration specifiers or '...' before 'Pixmap'
/usr/include/tkDecls.h:603: error: expected declaration specifiers or '...' before 'Colormap'
/usr/include/tkDecls.h:606: error: expected declaration specifiers or '...' before 'Visual'
/usr/include/tkDecls.h:606: error: expected declaration specifiers or '...' before 'Colormap'
/usr/include/tkDecls.h:610: error: expected ')' before '*' token
/usr/include/tkDecls.h:627: error: expected ')' before '*' token
/usr/include/tkDecls.h:632: error: expected ')' before '*' token
/usr/include/tkDecls.h:649: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Tk_AllocBitmapFromObj'
/usr/include/tkDecls.h:657: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
/usr/include/tkDecls.h:702: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Tk_GetBitmapFromObj'
/usr/include/tkDecls.h:705: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
/usr/include/tkDecls.h:772: error: expected ')' before '*' token
/usr/include/tkDecls.h:775: error: expected ')' before '*' token
/usr/include/tkDecls.h:788: error: expected declaration specifiers or '...' before 'GC'
/usr/include/tkDecls.h:795: error: expected declaration specifiers or '...' before 'GC'
/usr/include/tkDecls.h:801: error: expected declaration specifiers or '...' before 'Pixmap'
/usr/include/tkDecls.h:806: error: expected declaration specifiers or '...' before 'XColor'
/usr/include/tkDecls.h:821: error: expected declaration specifiers or '...' before 'Pixmap'
/usr/include/tkDecls.h:866: error: expected ')' before '*' token
/usr/include/tkDecls.h:915: error: expected declaration specifiers or '...' before 'Drawable'
/usr/include/tkDecls.h:932: error: expected specifier-qualifier-list before 'XColor'

Failed to find the necessary bits to build these modules:
_bsddb             bsddb185           gdbm            
linuxaudiodev      ossaudiodev                        
To find the necessary bits, look in setup.py in detect_modules() for the module's name.


Failed to build these modules:
_curses            _curses_panel      _socket         
_ssl               _tkinter           sunaudiodev     

running build_scripts
./python -E -c 'import sys ; from distutils.util import get_platform ; print get_platform()+"-"+sys.version[0:3]' >platform
find ./Lib -name '*.py[co]' -print | xargs rm -f
./python -E -tt ./Lib/test/regrtest.py -l 
Traceback (most recent call last):
  File "./Lib/test/regrtest.py", line 168, in <module>
    from test import test_support
  File "/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Lib/test/test_support.py", line 8, in <module>
    import socket
  File "/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Lib/socket.py", line 46, in <module>
    import _socket
ImportError: No module named _socket
make: [test] Error 1 (ignored)
./python -E -tt ./Lib/test/regrtest.py -l 
Traceback (most recent call last):
  File "./Lib/test/regrtest.py", line 168, in <module>
    from test import test_support
  File "/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Lib/test/test_support.py", line 8, in <module>
    import socket
  File "/export/home/drkirkby/parallel/sage-4.4.4/spkg/standard/python-2.6.6/src/Lib/socket.py", line 46, in <module>
    import _socket
ImportError: No module named _socket
make: *** [test] Error 1

> I appreciate your point. But do you know if anyone has it on their
> TODO list?

It's on my todo list, but that still might mean I can only get to
it next year.

> If not, is there anything I could do about it?

You could invoke the 5-for-one deal. Review 5 issues, and I'll deal with
this one.

I think I spoke too soon. 

I just downloaded the 2.7.rc2. Using both 32 and 64-bit builds, with the only patch being that I attached to issue8852  some months back, the problem occurs again. 

test_float
test test_float failed -- Traceback (most recent call last):
  File "/export/home/drkirkby/Python-2.7rc2/Lib/test/test_float.py", line 1297, in test_roundtrip
    self.identical(-x, roundtrip(-x))
  File "/export/home/drkirkby/Python-2.7rc2/Lib/test/test_float.py", line 907, in identical
    self.fail('%r not identical to %r' % (x, y))
AssertionError: -0.0 not identical to 0.0

test_fnmatch
test_fork1

Sorry, I put that note on the wrong issue!

ignore it.

I'm also seeing the failure of the _socket module to build on OpenSolaris build snv_134 (the most recent development build).  The socketmodule.c.patch patch fixes that failure for me, allowing the test-suite to run.

I'm afraid I don't feel competent to comment on the correctness of the patch, though, other than to say it works for me.

Thank you Mark for confirming what I found. 

I understand your reservations about the code if you don't know of its correctness. I must admit I don't myself. I don't have a clue how this _socket module should be built. 

But it is clear to me that the original code is attempting to compile code using PACKET_LOOPBACK, PACKET_FASTROUTE and SIOCGIFNAME, despite they are not defined. Although I'm not a mind-reader, I believer the original programmer probably thought they were defined in the header file netpacket/packet.h, when in fact they are not on Solaris. 

I wish I could take Martin v. Löwis up on his "5-for-one deal", where I review 5 issues and he deals with this one. Unfortunately, I'm very new to python, so really are not going to be a lot of help to anyone in reviewing issues. I will just have to keep that patch in Sage until it either gets to the top of Martin's TODO list, or someone else deals with it. 

Dave

David's patch works here (OpenSolaris build 134).

The posted patch: better if the PACKET_* tests were just at the two missing ones rather than removing all of the ones that are actually there like PACKET_OUTGOING.

Ok, here is an updated patch with finer-grained constants injection.

Committed in r85868 (3.2), r85869 (3.1) and r85870 (2.7). Thank you.