This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: curses patch add color_set and wcolor_set , and addchstr family of functions
Type: enhancement Stage: patch review
Components: Extension Modules Versions: Python 3.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: georg.brandl, serhiy.storchaka, steve@integrityintegrators.net
Priority: normal Keywords: patch

Created on 2009-02-25 17:30 by steve@integrityintegrators.net, last changed 2022-04-11 14:56 by admin.

Files
File name Uploaded Description Edit
test_curses_color_set.py steve@integrityintegrators.net, 2009-02-25 17:30 The unit test.
curses_patch.diff steve@integrityintegrators.net, 2009-02-27 01:23 The diff file for Modules/_cursesmodule.c review
test_curses_addchstr.py steve@integrityintegrators.net, 2009-02-27 01:24 Unit test for addchstr family.
lib_curses_rst.diff steve@integrityintegrators.net, 2009-02-27 15:12 Diff for Docs/library/curses.rst review
howto_curses_rst.diff steve@integrityintegrators.net, 2009-02-27 15:21 Diff file for Docs/howto/curses.rst review
whatsnew_2_7_rst.diff steve@integrityintegrators.net, 2009-02-27 15:41 Diff file for the Docs/whatsnew/2.7.rst file. review
Messages (10)
msg82709 - (view) Author: Steve Owens (steve@integrityintegrators.net) Date: 2009-02-25 17:30
Not sure what to set theType field to, this is my first patch 
submission.  The attached files are a unit test 
test_curses_color_set.py and the diff color_set_diff, apparently I can 
only attach one fo thetwo files.
msg82751 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2009-02-26 10:08
Why was this classified as "documentation"?
msg82758 - (view) Author: Steve Owens (steve@integrityintegrators.net) Date: 2009-02-26 14:21
According to the python.org website: http://python.org/dev/patches/

We were to submit Documentation patches as Documentation, but it did'nt
say what to submit other types of patches as, so I took a chance.

How should it have been submitted?

Best Regards,
Steve Owens
>
> Georg Brandl <georg@python.org> added the comment:
>
> Why was this classified as "documentation"?
>
> ----------
> components: +Extension Modules -Documentation
>
> _______________________________________
> Python tracker <report@bugs.python.org>
> <http://bugs.python.org/issue5368>
> _______________________________________
>
msg82804 - (view) Author: Steve Owens (steve@integrityintegrators.net) Date: 2009-02-27 01:23
I have also added the addchstr family of functions.  The updated patch2
should include the previos patch since it has not been applied to the
repository as of this writing.  See also the unittest for the addchstr
method family.

I will update the docs and add those as well, but there is quite alot of
documentation that needs to be done and it is late, please let me know
if this will be an acceptable patch. I'm still new.
msg82805 - (view) Author: Steve Owens (steve@integrityintegrators.net) Date: 2009-02-27 01:24
This is the addchstr unit test.
msg82806 - (view) Author: Steve Owens (steve@integrityintegrators.net) Date: 2009-02-27 01:25
This is a start on the documentation efforts.  I have updated the
recently modified curses.rst (how to) file.  Need direction in locating
all of the docs that are impacted by the changes I have introduced and I
will write them up.
msg82833 - (view) Author: Steve Owens (steve@integrityintegrators.net) Date: 2009-02-27 15:12
I am attaching the diff file for the Docs/library/curses.rst as 
lib_curses_rst.diff
msg82834 - (view) Author: Steve Owens (steve@integrityintegrators.net) Date: 2009-02-27 15:14
I am attaching the Docs/howto/curses.rst file as howto_curses_rst.diff
msg82835 - (view) Author: Steve Owens (steve@integrityintegrators.net) Date: 2009-02-27 15:49
I am not familiar with the process here, but I would like to continue 
to add additional support to the _cursesmodule.c file.  However, I am 
loathe to put too much functionality into any one patch.  Is there any 
way I can find out when this patch will be applied so that I can get 
latest and then move forward incrementally?
msg99800 - (view) Author: A.M. Kuchling (akuchling) * (Python committer) Date: 2010-02-22 18:26
Thanks for the patches!  Two comments on the addchstr change:

* I think that, instead of checking for a list, the method should accept any Python sequence; a tuple is perfectly reasonable, for example, and if the code is changed to use PyCurses_ConvertToChType() instead of PyInt_Check(), it will accept a list of integers, a mixed list of ints and character strings, and even just strings.

* the documentation and error messages currently try to paper over all of the curses variants of addchstr(), waddchstr(), mvwaddchstr(), ..., covering them all up under the addchstr name.  This means that your submitted documentation patch is too detailed; it should look more like the insnstr() docs, which has [y,x,] as optional, and the text says something like "Moves to y,x if specified, and then ...'.

The color_set() changes look OK; I'm going to try to break them out into a separate patch and commit them on their own.
History
Date User Action Args
2022-04-11 14:56:46adminsetgithub: 49618
2017-11-01 18:55:37serhiy.storchakasetversions: + Python 3.7, - Python 2.7
2017-11-01 18:04:46serhiy.storchakasetassignee: serhiy.storchaka

nosy: + serhiy.storchaka
2014-12-31 16:19:57akuchlingsetnosy: - akuchling
2010-12-14 18:38:46r.david.murraysettype: enhancement
stage: patch review
2010-11-12 20:57:57akuchlingsetassignee: akuchling -> (no value)
2010-02-22 18:26:59akuchlingsetmessages: + msg99800
2010-01-06 15:48:40akuchlingsetassignee: georg.brandl -> akuchling
2009-02-27 15:49:07steve@integrityintegrators.netsetmessages: + msg82835
2009-02-27 15:41:35steve@integrityintegrators.netsetfiles: - color_set_patch.diff
2009-02-27 15:41:27steve@integrityintegrators.netsetfiles: - curses.rst
2009-02-27 15:41:05steve@integrityintegrators.netsetfiles: + whatsnew_2_7_rst.diff
2009-02-27 15:21:10steve@integrityintegrators.netsetfiles: + howto_curses_rst.diff
2009-02-27 15:20:53steve@integrityintegrators.netsetfiles: - howto_curses_rst.diff
2009-02-27 15:15:00steve@integrityintegrators.netsetfiles: + howto_curses_rst.diff
messages: + msg82834
2009-02-27 15:12:29steve@integrityintegrators.netsetfiles: + lib_curses_rst.diff
messages: + msg82833
2009-02-27 01:25:41steve@integrityintegrators.netsetfiles: + curses.rst
messages: + msg82806
2009-02-27 01:24:27steve@integrityintegrators.netsetfiles: + test_curses_addchstr.py
messages: + msg82805
2009-02-27 01:23:21steve@integrityintegrators.netsetfiles: + curses_patch.diff
messages: + msg82804
title: curses patch add color_set and wcolor_set functions -> curses patch add color_set and wcolor_set , and addchstr family of functions
2009-02-26 22:24:28akuchlingsetnosy: + akuchling
2009-02-26 19:42:01steve@integrityintegrators.netsetcomponents: + Extension Modules, - Library (Lib)
2009-02-26 19:41:16steve@integrityintegrators.netsetcomponents: + Library (Lib), - Extension Modules
2009-02-26 14:21:46steve@integrityintegrators.netsetmessages: + msg82758
2009-02-26 10:08:42georg.brandlsetmessages: + msg82751
components: + Extension Modules, - Documentation
2009-02-25 17:30:49steve@integrityintegrators.netsetfiles: + test_curses_color_set.py
2009-02-25 17:30:28steve@integrityintegrators.netcreate