This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Copy pgort140.dll when building for PGO
Type: enhancement Stage: resolved
Components: Build, Windows Versions: Python 3.11, Python 3.10, Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: steve.dower Nosy List: neonene, paul.moore, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: patch

Created on 2022-03-23 20:00 by steve.dower, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 32083 merged steve.dower, 2022-03-23 20:03
PR 32146 closed neonene, 2022-03-28 04:40
PR 32366 merged steve.dower, 2022-04-06 14:33
PR 32407 merged steve.dower, 2022-04-07 22:23
Messages (5)
msg415905 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2022-03-23 20:00
Rather than trying to set up PATH properly, we should just copy pgort140.dll into the build directory when building instrumented version.

This becomes more important for those (i.e. me) building and then manually running the profile stage on a different machine.
msg416854 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2022-04-06 10:56
New changeset 074da788028c1f1e867dc81698efdcdc263f2288 by Steve Dower in branch 'main':
bpo-47103: Copy pgort140.dll into output directory when building PGInstrument on Windows (GH-32083)
https://github.com/python/cpython/commit/074da788028c1f1e867dc81698efdcdc263f2288
msg416908 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2022-04-06 23:12
Backport is blocked on issue47104 (or a randomly successful CI run, which seems to occur occasionally).
msg416947 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2022-04-07 22:21
New changeset b0ec17b6d9e0fb61081b6d15a1b2a14b607851b7 by Steve Dower in branch '3.10':
bpo-47103: Copy pgort140.dll into output directory when building PGInstrument on Windows (GH-32083)
https://github.com/python/cpython/commit/b0ec17b6d9e0fb61081b6d15a1b2a14b607851b7
msg416952 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2022-04-08 00:03
New changeset 80c115385c01f456cdc6550543cf2112ae7a8161 by Steve Dower in branch '3.9':
bpo-47103: Copy pgort140.dll into output directory when building PGInstrument on Windows (GH-32083)
https://github.com/python/cpython/commit/80c115385c01f456cdc6550543cf2112ae7a8161
History
Date User Action Args
2022-04-11 14:59:57adminsetgithub: 91259
2022-04-08 11:04:30steve.dowersetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2022-04-08 00:03:06steve.dowersetmessages: + msg416952
2022-04-07 22:23:30steve.dowersetpull_requests: + pull_request30432
2022-04-07 22:21:10steve.dowersetmessages: + msg416947
2022-04-06 23:12:09steve.dowersetmessages: + msg416908
versions: + Python 3.9, Python 3.10
2022-04-06 14:33:29steve.dowersetpull_requests: + pull_request30413
2022-04-06 10:56:35steve.dowersetmessages: + msg416854
2022-03-28 04:40:58neonenesetnosy: + neonene
pull_requests: + pull_request30226
2022-03-23 20:03:01steve.dowersetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request30170
2022-03-23 20:00:21steve.dowercreate