This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Modules/makesetup generated rules ignore *disabled*
Type: enhancement Stage: resolved
Components: Build Versions: Python 3.11
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: christian.heimes
Priority: normal Keywords: patch

Created on 2021-12-09 09:23 by christian.heimes, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 30001 merged christian.heimes, 2021-12-09 09:27
PR 30100 merged christian.heimes, 2021-12-14 14:12
PR 32234 merged christian.heimes, 2022-04-01 14:13
Messages (5)
msg408091 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2021-12-09 09:23
Modules/Setup can disable a module. However makesetup does not take *disabled* into account when it generated Makefile.

Example:

---Modules/Setup.local

*disabled*
pwd
---

makesetup generates a Makefile with "pwd" in MODDISABLED_NAMES and MODBUILT_NAMES. Because "pwd" is in MODBUILT_NAMES the module is built and included in python binary.

Expected result:
"pwd" module should not be built.
msg408208 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2021-12-10 13:12
New changeset 036bbb1d1b6156a1a72c40e9f907f302505085bc by Christian Heimes in branch 'main':
bpo-46023: Fix makesetup handling of disabled rule (GH-30001)
https://github.com/python/cpython/commit/036bbb1d1b6156a1a72c40e9f907f302505085bc
msg408523 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2021-12-14 11:53
GH-30001 may have introduced a regression. makesetup is dropping too many modules. Back to the drawing board!
msg408531 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2021-12-14 14:42
New changeset 74821b30539bba3cf0ac4148923ec0e9b826508e by Christian Heimes in branch 'main':
bpo-46023: Skip build if module is marked as DISABLED (GH-30100)
https://github.com/python/cpython/commit/74821b30539bba3cf0ac4148923ec0e9b826508e
msg416493 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2022-04-01 15:23
New changeset abdd69c95c1711c2dc75be4e784c6d6c80a409b9 by Christian Heimes in branch 'main':
bpo-46023: makesetup: skip all duplicate modules (GH-32234)
https://github.com/python/cpython/commit/abdd69c95c1711c2dc75be4e784c6d6c80a409b9
History
Date User Action Args
2022-04-11 14:59:53adminsetgithub: 90181
2022-04-01 20:04:34christian.heimessetstatus: open -> closed
type: enhancement
resolution: fixed
stage: patch review -> resolved
2022-04-01 15:23:21christian.heimessetmessages: + msg416493
2022-04-01 14:13:34christian.heimessetpull_requests: + pull_request30306
2021-12-14 14:42:56christian.heimessetmessages: + msg408531
2021-12-14 14:12:58christian.heimessetpull_requests: + pull_request28322
2021-12-14 11:53:02christian.heimessetmessages: + msg408523
2021-12-10 13:12:06christian.heimessetmessages: + msg408208
2021-12-09 09:27:32christian.heimessetkeywords: + patch
stage: patch review
pull_requests: + pull_request28225
2021-12-09 09:23:50christian.heimescreate