➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2021-08-31 07:24 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 28081 | merged | serhiy.storchaka, 2021-08-31 07:27 | |
| PR 28101 | merged | miss-islington, 2021-08-31 17:45 | |
| PR 28103 | merged | serhiy.storchaka, 2021-08-31 17:51 | |
| Messages (5) | |||
|---|---|---|---|
| msg400697 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2021-08-31 07:24 | |
RegressionTestResult is a subclass of TextTestResult, but it completely ignores the TextTestResult function of outputting results and re-implements it. The problem of this is not only duplicating the code, but that if TextTestResult is changed (for example to fix issue25894) the corresponding changes should be re-implemented in RegressionTestResult. And since implementations that produce the same result are different (somewhere in subtle way), it adds much work and is errorprone. The proposed PR removes any text output code from RegressionTestResult and allows to use TextTestResult for output. |
|||
| msg400698 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2021-08-31 07:46 | |
RegressionTestResult was introduced in issue34582. |
|||
| msg400761 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2021-08-31 17:45 | |
New changeset 2b76a5322fdf71d62b531fd765085f96f981c244 by Serhiy Storchaka in branch 'main': bpo-45057: Simplify RegressionTestResult (GH-28081) https://github.com/python/cpython/commit/2b76a5322fdf71d62b531fd765085f96f981c244 |
|||
| msg400813 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2021-09-01 06:45 | |
New changeset e527f79fa8b472dd534fc360e998fe8213e6471e by Serhiy Storchaka in branch '3.9': [3.9] bpo-45057: Simplify RegressionTestResult (GH-28081) (GH-28103) https://github.com/python/cpython/commit/e527f79fa8b472dd534fc360e998fe8213e6471e |
|||
| msg400814 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2021-09-01 06:45 | |
New changeset 3d56272e4ecaef9f38c1f48430364701d34b3ee4 by Miss Islington (bot) in branch '3.10': bpo-45057: Simplify RegressionTestResult (GH-28081) (GH-28101) https://github.com/python/cpython/commit/3d56272e4ecaef9f38c1f48430364701d34b3ee4 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:49 | admin | set | github: 89220 |
| 2021-09-01 06:52:03 | serhiy.storchaka | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2021-09-01 06:45:50 | serhiy.storchaka | set | messages: + msg400814 |
| 2021-09-01 06:45:13 | serhiy.storchaka | set | messages: + msg400813 |
| 2021-08-31 17:51:48 | serhiy.storchaka | set | pull_requests: + pull_request26546 |
| 2021-08-31 17:45:19 | miss-islington | set | nosy:
+ miss-islington pull_requests: + pull_request26544 |
| 2021-08-31 17:45:18 | serhiy.storchaka | set | messages: + msg400761 |
| 2021-08-31 07:46:48 | serhiy.storchaka | set | versions: + Python 3.9, Python 3.10, Python 3.11 |
| 2021-08-31 07:46:17 | serhiy.storchaka | set | nosy:
+ vstinner, rbcollins, ezio.melotti, michael.foord, steve.dower messages: + msg400698 |
| 2021-08-31 07:27:49 | serhiy.storchaka | set | keywords:
+ patch stage: patch review pull_requests: + pull_request26524 |
| 2021-08-31 07:24:28 | serhiy.storchaka | create | |