classification
Title: Remove dead code from Tkinter.py
Type: behavior Stage: patch review
Components: Versions: Python 3.2, Python 3.1, Python 2.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: BreamoreBoy, gpolo, pysquared
Priority: normal Keywords: patch

Created on 2008-11-19 00:14 by gpolo, last changed 2011-03-06 15:50 by gpolo.

Files
File name Uploaded Description Edit
remove_dead_code.diff gpolo, 2008-11-19 00:14
Messages (4)
msg76030 - (view) Author: Guilherme Polo (gpolo) * (Python committer) Date: 2008-11-19 00:14
There are some methods (which call tk commands) that no longer exist,
for a long time now so this patch remove them.

There are also these "indices" functions, which do not belong to the
module space and now are gone too.
msg112873 - (view) Author: Mark Lawrence (BreamoreBoy) Date: 2010-08-04 19:45
Ther title says it all, can we commit this?
msg129263 - (view) Author: Graham Horler (pysquared) Date: 2011-02-24 14:36
Are we sure this is dead code, and not just out of date?

e.g. this works, and I use it in production with "if Tkinter.TkVersion >= 8.4":

b = Tkinter.Button(root)
b.tk.call('tk::ButtonEnter', b._w)
msg130175 - (view) Author: Guilherme Polo (gpolo) * (Python committer) Date: 2011-03-06 15:50
If we consider the meaning of "dead code" as that used in compilers, then I meant "out of date" code.

If you want to add support for tk::ButtonEnter then I believe you should open a new issue and raise your points there. Anyway, have you read http://www.mail-archive.com/python-list@python.org/msg210494.html ? Does it relate to your use case ?
History
Date User Action Args
2011-03-06 15:50:59gpolosetnosy: pysquared, gpolo, BreamoreBoy
messages: + msg130175
2011-02-24 14:36:20pysquaredsetnosy: + pysquared
messages: + msg129263
2010-08-04 19:45:21BreamoreBoysetversions: + Python 3.1, Python 3.2, - Python 3.0
nosy: + BreamoreBoy

messages: + msg112873

type: behavior
stage: patch review
2009-02-09 22:04:09gpololinkissue775309 superseder
2008-11-19 00:14:18gpolocreate