➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2021-02-22 10:06 by erlendaasland, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 24658 | merged | erlendaasland, 2021-02-26 08:48 | |
| Messages (2) | |||
|---|---|---|---|
| msg387510 - (view) | Author: Erlend E. Aasland (erlendaasland) *  |
Date: 2021-02-22 10:06 | |
In Modules/_sqlite/connection.c: pysqlite_connection_commit_impl(), pysqlite_connection_rollback_impl(), and _pysqlite_connection_begin() all call sqlite3_prepare_v2() with the fourth parameter (pzTail) set. This (output) parameter is never used, we can safely remove the tail variables, and just call sqlite3_prepare_v2() with NULL as the fourth parameter. Also, there's a lot of code duplication here. A support function could help simplify this, but that's out of scope. |
|||
| msg387725 - (view) | Author: Berker Peksag (berker.peksag) *  |
Date: 2021-02-26 14:30 | |
New changeset 5e48e836883ac577acd69c7b9bdfe5c439cef47f by Erlend Egeberg Aasland in branch 'master': bpo-43294: Remove unused variables in pysqlite_connection_*() (GH-24658) https://github.com/python/cpython/commit/5e48e836883ac577acd69c7b9bdfe5c439cef47f |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:41 | admin | set | github: 87460 |
| 2021-02-26 14:30:54 | berker.peksag | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2021-02-26 14:30:29 | berker.peksag | set | messages: + msg387725 |
| 2021-02-26 08:48:07 | erlendaasland | set | keywords:
+ patch stage: patch review pull_requests: + pull_request23443 |
| 2021-02-22 10:06:47 | erlendaasland | create | |