➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2020-01-11 15:52 by corona10, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 18045 | closed | python-dev, 2020-01-17 22:59 | |
| PR 19817 | merged | corona10, 2020-04-30 15:24 | |
| Messages (8) | |||
|---|---|---|---|
| msg359803 - (view) | Author: Dong-hee Na (corona10) *  |
Date: 2020-01-11 15:52 | |
See: https://github.com/python/cpython/pull/17939#pullrequestreview-341290152 There was partial refactoring through PR 17939. I and Victor think that nntplib._NNTPBase can be removed by merging nntplib._NNTPBase and nntplib.NNTP. The only care point would be rewriting unit testing code which depends on nntplib._NNTPBase. |
|||
| msg359989 - (view) | Author: Luciana (lucianamarques) * | Date: 2020-01-14 20:29 | |
Hey, I'm taking a look into this! |
|||
| msg360012 - (view) | Author: Dong-hee Na (corona10) * |
Date: 2020-01-14 23:32 | |
@lucianamarques Good news, if you submit the patch. Please ping me and @vstinner :) |
|||
| msg360066 - (view) | Author: Luciana (lucianamarques) * | Date: 2020-01-15 17:15 | |
Thank you, I am creating the patch now and will submit it later today! |
|||
| msg360218 - (view) | Author: Luciana (lucianamarques) * | Date: 2020-01-17 23:10 | |
I just uploaded the PR, please take a look when you have a chance :) I did my best trying to come up with a good code. |
|||
| msg369038 - (view) | Author: Dong-hee Na (corona10) * |
Date: 2020-05-16 10:31 | |
New changeset aa92a7cf210c98ad94229f282221136d846942db by Dong-hee Na in branch 'master': bpo-39305: Update nntplib to merge nntplib.NNTP and nntplib._NNTPBase (GH-19817) https://github.com/python/cpython/commit/aa92a7cf210c98ad94229f282221136d846942db |
|||
| msg369039 - (view) | Author: Dong-hee Na (corona10) * |
Date: 2020-05-16 10:33 | |
I am no closing this issue :) Thank you for the suggestion, Victor. And also thank you for the interest in this issue, Luciana :) |
|||
| msg369052 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2020-05-16 15:23 | |
Thanks, that's a nice simplification of the code ;-) |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:25 | admin | set | github: 83486 |
| 2020-05-16 15:23:15 | vstinner | set | messages: + msg369052 |
| 2020-05-16 10:33:18 | corona10 | set | status: open -> closed resolution: fixed messages: + msg369039 stage: patch review -> resolved |
| 2020-05-16 10:31:57 | corona10 | set | messages: + msg369038 |
| 2020-04-30 15:24:45 | corona10 | set | pull_requests: + pull_request19137 |
| 2020-01-17 23:10:16 | lucianamarques | set | messages: + msg360218 |
| 2020-01-17 22:59:50 | python-dev | set | keywords:
+ patch stage: patch review pull_requests: + pull_request17439 |
| 2020-01-15 17:15:10 | lucianamarques | set | messages: + msg360066 |
| 2020-01-14 23:32:13 | corona10 | set | messages: + msg360012 |
| 2020-01-14 20:29:55 | lucianamarques | set | nosy:
+ lucianamarques messages: + msg359989 |
| 2020-01-11 15:52:28 | corona10 | create | |