➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2017-10-18 15:22 by vstinner, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 4054 | closed | CuriousLearner, 2017-10-19 19:15 | |
| PR 4057 | merged | vstinner, 2017-10-20 10:21 | |
| PR 4140 | merged | tomfloyer, 2017-11-08 17:31 | |
| Messages (6) | |||
|---|---|---|---|
| msg304582 - (view) | Author: STINNER Victor (vstinner) *  |
Date: 2017-10-18 15:22 | |
Recently, a new "cell_set_contents()" public symbol was added by mistake: see bpo-30486. It was quickly noticed by doko, and fixed by me (commit 0ad05c32cc41d4c21bfd78b9ffead519ead475a2). The problem is that we already have a "make smelly" command to check if Python "leaks" symbols, but this check is not run on our CIs (Travis CI or buildbots). It would be nice to run automatically this test. |
|||
| msg304632 - (view) | Author: Sanyam Khurana (CuriousLearner) *  |
Date: 2017-10-19 18:25 | |
Hi Haypo, I'd like to work on a patch for this issue. Can you please guide me how the tests are configured for buildbots? |
|||
| msg304634 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-10-19 18:32 | |
Sanyam: please first try to write a change for Travis CI: modify .travis.yml, create a PR and check if it works. |
|||
| msg304871 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-10-24 08:29 | |
New changeset 87d332dcdbffe8ff60d99f74b1ad241c0967b055 by Victor Stinner in branch 'master': bpo-31810: Add smelly.py to check exported symbols (#4057) https://github.com/python/cpython/commit/87d332dcdbffe8ff60d99f74b1ad241c0967b055 |
|||
| msg304880 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-10-24 09:15 | |
"make smelly" is now run on Travis CI. |
|||
| msg305883 - (view) | Author: Yury Selivanov (yselivanov) * |
Date: 2017-11-08 17:31 | |
New changeset bf9d317626eebcf79bd0756b4dd43df82d5cc186 by Yury Selivanov (Tom Floyer) in branch 'master': bpo-31810: added missing keywords to docs. (#4140) https://github.com/python/cpython/commit/bf9d317626eebcf79bd0756b4dd43df82d5cc186 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:53 | admin | set | github: 75991 |
| 2017-11-08 17:31:33 | yselivanov | set | nosy:
+ yselivanov messages: + msg305883 |
| 2017-11-08 17:31:28 | tomfloyer | set | pull_requests: + pull_request4300 |
| 2017-11-08 17:20:36 | vstinner | set | pull_requests: - pull_request4299 |
| 2017-11-08 17:18:28 | tomfloyer | set | pull_requests: + pull_request4299 |
| 2017-10-26 18:33:29 | zach.ware | set | pull_requests: - pull_request4103 |
| 2017-10-26 18:06:13 | tomfloyer | set | pull_requests: + pull_request4103 |
| 2017-10-24 09:15:51 | vstinner | set | status: open -> closed resolution: fixed messages: + msg304880 stage: patch review -> resolved |
| 2017-10-24 08:29:55 | vstinner | set | messages: + msg304871 |
| 2017-10-20 19:32:25 | ned.deily | set | nosy:
+ ned.deily |
| 2017-10-20 10:21:29 | vstinner | set | pull_requests: + pull_request4026 |
| 2017-10-20 07:43:10 | taleinat | set | nosy:
+ taleinat |
| 2017-10-19 19:15:41 | CuriousLearner | set | keywords:
+ patch stage: patch review pull_requests: + pull_request4023 |
| 2017-10-19 18:32:46 | vstinner | set | messages: + msg304634 |
| 2017-10-19 18:25:40 | CuriousLearner | set | nosy:
+ CuriousLearner messages: + msg304632 |
| 2017-10-18 15:22:59 | vstinner | create | |