classification
Title: readline module has obsolete code
Type: enhancement Stage: resolved
Components: Extension Modules Versions: Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: pitrou
Priority: low Keywords:

Created on 2017-07-17 10:31 by pitrou, last changed 2017-07-18 15:05 by pitrou. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 2738 merged pitrou, 2017-07-17 10:33
Messages (3)
msg298479 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2017-07-17 10:31
The readline module has obsolete code for platforms where GNU readline is older than 2.1 or where select() is not available.
msg298480 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2017-07-17 10:53
According to https://ftp.gnu.org/gnu/readline/, GNU readline 2.1 was released in 1997... We could probably even require 5.0 (released in 2004), but it raises the question of which functions are supported by third-party emulations such as libedit.
msg298594 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2017-07-18 15:05
New changeset f474c5a3f3c1fbc0383800b88e8518d43a52d1d1 by Antoine Pitrou in branch 'master':
bpo-30946: Remove obsolete fallback code in readline module (#2738)
https://github.com/python/cpython/commit/f474c5a3f3c1fbc0383800b88e8518d43a52d1d1
History
Date User Action Args
2017-07-18 15:05:24pitrousetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2017-07-18 15:05:09pitrousetmessages: + msg298594
2017-07-17 10:53:25pitrousetstage: needs patch -> patch review
2017-07-17 10:53:16pitrousetmessages: + msg298480
2017-07-17 10:33:48pitrousetpull_requests: + pull_request2798
2017-07-17 10:31:54pitroucreate