classification
Title: Pull Windows dependencies from GitHub rather than svn.python.org
Type: resource usage Stage: patch review
Components: Build, Extension Modules, Windows Versions: Python 3.7, Python 3.6, Python 3.5, Python 2.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: zach.ware Nosy List: ammar2, benjamin.peterson, paul.moore, pitrou, schen, steve.dower, tim.golden, zach.ware
Priority: normal Keywords:

Created on 2017-05-24 01:33 by zach.ware, last changed 2017-06-25 06:08 by ammar2.

Pull Requests
URL Status Linked Edit
PR 1783 merged zach.ware, 2017-05-24 01:35
PR 2236 merged zach.ware, 2017-06-16 03:30
PR 2237 merged zach.ware, 2017-06-16 03:45
Messages (13)
msg294307 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2017-05-24 01:33
Once we've migrated away from svn.python.org for Windows build dependencies, there should be no reason to continue running svn.python.org.
msg294359 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2017-05-24 15:00
The reason to keep it running is for all the existing people who are building from source. Unless you're porting all the old versions over and providing instructions for updating old sources? I wouldn't bother - just leave the server up for a few more years.

Ben probably knows - can we add a custom message to svn requests? Then we could start publicising an end of life date for it.
msg294441 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2017-05-25 07:00
The box svn is running on is at risk of falling over any day. Plus with whatever ancient software it's running, it's surely a security risk to keep running an unmaintained svn instance. I certainly don't want to keep it running for years. I don't think we've ever advertised the svn windows deps as a service we provide the community.

Off the top of my head, I'm not sure how to announce that deprecation to svn client users. If you find something on the internets, I can put it on the server.
msg294494 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2017-05-25 15:56
> I don't think we've ever advertised the svn windows deps as a service we provide the community.

Except in the dev guide :) ([after looking] well, linked from the dev guide https://github.com/python/cpython/blob/master/PCbuild/readme.txt#L230 )

Maybe we just need to pick a date and publicise it separately. Is this process PEP-worthy? Considering the amount of decisions we had to make regarding putting code in git, it might be worth writing up how it works in a brief PEP and including an EOL for svn.p.o
msg294533 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2017-05-26 06:41
How far along are you with removing the svn.python.org dependency. Does  Jan 1 2018 sound okay for the end of svn.python.org?

I think a PEP is up to you. Doesn't seem like something that needs to be approved.
msg294534 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2017-05-26 07:34
I could imagine people wanting to build old releases.  But we have Windows binaries up here:
https://www.python.org/ftp/python/

Therefore I don't think it's a problem to discontinue svn.python.org once new releases are migrated to github (but only once those new releases are out).
msg295240 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2017-06-06 04:50
I just disabled viewvc on svn.python.org because of a security problem.
msg296150 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2017-06-16 03:08
New changeset 51599e2bdd10ab77212a7cbb41a13ea70ee13da8 by Zachary Ware in branch 'master':
bpo-30450: Pull Windows dependencies from GitHub rather than svn (GH-1783)
https://github.com/python/cpython/commit/51599e2bdd10ab77212a7cbb41a13ea70ee13da8
msg296157 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2017-06-16 03:35
New changeset cb8c0485ab1e3aeb4f64e76177aabbc6eba5a0ef by Zachary Ware in branch 'master':
bpo-30450: Add NEWS and whatsnew (GH-2236)
https://github.com/python/cpython/commit/cb8c0485ab1e3aeb4f64e76177aabbc6eba5a0ef
msg296160 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2017-06-16 06:06
New changeset 04431c926a88be433203f89e3577addd0d41b602 by Zachary Ware in branch '3.6':
bpo-30450: Pull Windows dependencies from GitHub rather than svn (GH-1783) (GH-2237)
https://github.com/python/cpython/commit/04431c926a88be433203f89e3577addd0d41b602
msg296351 - (view) Author: (schen) Date: 2017-06-19 15:50
The usage text in build.bat still mentions that svn.exe is required for the '-e' flag. I think it should be updated to reflect the changes made.
msg296365 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2017-06-19 18:24
Zach, I just spotted this build log, that appears to have failed to download nuget.exe: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.6/builds/339/steps/compile/logs/stdio

Guessing the bot is only succeeding because it currently has all the dependencies. Maybe we should consider just checking in nuget.exe?
msg296805 - (view) Author: Ammar Askar (ammar2) * Date: 2017-06-25 06:08
Looks like that error is coming from the fact that the Powershell on that buildbot is outdated. As the documentation notes:

https://msdn.microsoft.com/en-us/powershell/reference/5.1/microsoft.powershell.utility/invoke-webrequest

> This cmdlet was introduced in Windows PowerShell 3.0.


Before running the web request command maybe do a `powershell.exe -Command $PSVersionTable.PSVersion` in order to debug this issue on any other machines?
History
Date User Action Args
2017-06-25 06:08:12ammar2setnosy: + ammar2
messages: + msg296805
2017-06-19 18:24:32steve.dowersetmessages: + msg296365
2017-06-19 15:50:42schensetnosy: + schen
messages: + msg296351
2017-06-16 06:06:38zach.waresetmessages: + msg296160
2017-06-16 03:45:04zach.waresetpull_requests: + pull_request2282
2017-06-16 03:35:01zach.waresetmessages: + msg296157
2017-06-16 03:30:17zach.waresetpull_requests: + pull_request2281
2017-06-16 03:08:53zach.waresetmessages: + msg296150
2017-06-06 04:50:21benjamin.petersonsetmessages: + msg295240
2017-05-26 07:34:41pitrousetnosy: + pitrou
messages: + msg294534
2017-05-26 06:41:31benjamin.petersonsetmessages: + msg294533
2017-05-25 15:56:55steve.dowersetmessages: + msg294494
2017-05-25 07:00:05benjamin.petersonsetmessages: + msg294441
2017-05-24 15:00:29steve.dowersetassignee: zach.ware

messages: + msg294359
nosy: + benjamin.peterson
2017-05-24 01:35:36zach.waresetpull_requests: + pull_request1864
2017-05-24 01:33:46zach.warecreate