This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Use after free in string '%c' formater
Type: behavior Stage: resolved
Components: Interpreter Core Versions: Python 3.7, Python 3.6, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: xiang.zhang Nosy List: python-dev, serhiy.storchaka, vstinner, xiang.zhang
Priority: normal Keywords: patch

Created on 2016-12-22 05:00 by xiang.zhang, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
use-after-free.patch xiang.zhang, 2016-12-22 05:00 review
Messages (5)
msg283811 - (view) Author: Xiang Zhang (xiang.zhang) * (Python committer) Date: 2016-12-22 05:00
In string %c formater(formatchar), when receiving an integer-like objects, the return value is decrefed immediately before use.
msg283813 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2016-12-22 05:30
LGTM.
msg283817 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2016-12-22 07:23
I reviewed the change and added minor comments. The change LGTM.
msg283819 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-12-22 07:38
New changeset e572c323fe53 by Xiang Zhang in branch '3.5':
Issue #29044: Fix a use-after-free in string '%c' formatter.
https://hg.python.org/cpython/rev/e572c323fe53

New changeset cc61d1d45291 by Xiang Zhang in branch '3.6':
Issue #29044: Merge 3.5.
https://hg.python.org/cpython/rev/cc61d1d45291

New changeset a1d5388d5da9 by Xiang Zhang in branch 'default':
Issue #29044: Merge 3.6.
https://hg.python.org/cpython/rev/a1d5388d5da9
msg283820 - (view) Author: Xiang Zhang (xiang.zhang) * (Python committer) Date: 2016-12-22 07:39
Thanks Serhiy and Victor. The final commits applies the comments. :-)
History
Date User Action Args
2022-04-11 14:58:41adminsetgithub: 73230
2016-12-22 07:39:27xiang.zhangsetstatus: open -> closed
resolution: fixed
messages: + msg283820

stage: commit review -> resolved
2016-12-22 07:38:09python-devsetnosy: + python-dev
messages: + msg283819
2016-12-22 07:23:59vstinnersetmessages: + msg283817
2016-12-22 05:30:45serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg283813

assignee: xiang.zhang
stage: patch review -> commit review
2016-12-22 05:00:07xiang.zhangcreate