This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Outdated part in the doc of PyUnicode_RichCompare
Type: Stage: resolved
Components: Documentation Versions: Python 3.7, Python 3.6, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: xiang.zhang Nosy List: docs@python, python-dev, serhiy.storchaka, vstinner, xiang.zhang
Priority: normal Keywords: patch

Created on 2016-12-19 04:30 by xiang.zhang, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
doc-of-PyUnicode_RichCompare.patch xiang.zhang, 2016-12-19 04:30 review
doc-of-PyUnicode_RichCompare_v2.patch xiang.zhang, 2016-12-19 06:08 review
Messages (6)
msg283578 - (view) Author: Xiang Zhang (xiang.zhang) * (Python committer) Date: 2016-12-19 04:30
The sentence:

"Note that Py_EQ and Py_NE comparisons can cause a UnicodeWarning in case the conversion of the arguments to Unicode fails with a UnicodeDecodeError."

in the doc of PyUnicode_RichCompare is not true in 3.x. Proposed patch simply deletes it.
msg283585 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2016-12-19 05:43
This sentence also is in the header.
msg283587 - (view) Author: Xiang Zhang (xiang.zhang) * (Python committer) Date: 2016-12-19 06:08
> This sentence also is in the header.

Ohh, yes. Thanks Serhiy!
msg283589 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2016-12-19 06:10
LGTM.
msg283600 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2016-12-19 10:08
doc-of-PyUnicode_RichCompare_v2.patch LGTM.
msg283605 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-12-19 10:43
New changeset 8f5ed2a38f64 by Xiang Zhang in branch '3.5':
Issue #29009: Remove outdated doc of PyUnicode_RichCompare.
https://hg.python.org/cpython/rev/8f5ed2a38f64

New changeset da958d01755a by Xiang Zhang in branch '3.6':
Issue #29009: Merge 3.5.
https://hg.python.org/cpython/rev/da958d01755a

New changeset 9568343fde42 by Xiang Zhang in branch 'default':
Issue #29009: Merge 3.6.
https://hg.python.org/cpython/rev/9568343fde42
History
Date User Action Args
2022-04-11 14:58:40adminsetgithub: 73195
2016-12-19 10:44:42xiang.zhangsetstatus: open -> closed
resolution: fixed
stage: commit review -> resolved
2016-12-19 10:43:42python-devsetnosy: + python-dev
messages: + msg283605
2016-12-19 10:08:12vstinnersetmessages: + msg283600
2016-12-19 06:10:37serhiy.storchakasetassignee: docs@python -> xiang.zhang
messages: + msg283589
stage: patch review -> commit review
2016-12-19 06:08:55xiang.zhangsetfiles: + doc-of-PyUnicode_RichCompare_v2.patch

messages: + msg283587
2016-12-19 05:43:13serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg283585
2016-12-19 04:30:59xiang.zhangcreate