➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2016-04-01 18:37 by berker.peksag, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| py_return_none_macro.diff | berker.peksag, 2016-04-01 18:37 | review | ||
| py_return_none_macro.cocci | serhiy.storchaka, 2016-04-01 20:50 | |||
| Messages (5) | |||
|---|---|---|---|
| msg262754 - (view) | Author: Berker Peksag (berker.peksag) *  |
Date: 2016-04-01 18:37 | |
The attached patch replaces all "Py_INCREF(Py_None); return Py_None;" lines with the Py_RETURN_NONE macro in sqlite3 module. |
|||
| msg262756 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2016-04-01 19:11 | |
py_return_none_macro.diff looks good to me. |
|||
| msg262769 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2016-04-01 20:50 | |
This patch and more can be generated by Сoccinelle [1] semantic patch.
spatch --in-place --dir . --sp-file py_return_none_macro.cocci
But be aware that some maintainers consider such sort of changes a code churn.
[1] http://coccinelle.lip6.fr/
|
|||
| msg263061 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2016-04-09 04:34 | |
New changeset b72f2d699563 by Berker Peksag in branch 'default': Issue #26687: Use Py_RETURN_NONE macro in sqlite3 module https://hg.python.org/cpython/rev/b72f2d699563 |
|||
| msg263062 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2016-04-09 04:39 | |
Thanks Victor and Serhiy. Сoccinelle looks like a useful tool, but I'm not planning to touch modules that I don't know well enough. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:29 | admin | set | github: 70874 |
| 2016-04-09 04:39:44 | berker.peksag | set | status: open -> closed resolution: fixed messages: + msg263062 stage: patch review -> resolved |
| 2016-04-09 04:34:06 | python-dev | set | nosy:
+ python-dev messages: + msg263061 |
| 2016-04-01 20:50:58 | serhiy.storchaka | set | files:
+ py_return_none_macro.cocci nosy: + serhiy.storchaka messages: + msg262769 |
| 2016-04-01 19:11:24 | vstinner | set | nosy:
+ vstinner messages: + msg262756 |
| 2016-04-01 18:37:32 | berker.peksag | set | files:
+ py_return_none_macro.diff keywords: + patch |
| 2016-04-01 18:37:10 | berker.peksag | create | |