This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: undefined name 'window' in Tools/scripts/fixdiv.py
Type: behavior Stage: resolved
Components: Demos and Tools Versions: Python 3.6, Python 3.4, Python 3.5, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: jayvdb, python-dev, serhiy.storchaka, terry.reedy
Priority: normal Keywords: patch

Created on 2015-10-29 06:37 by jayvdb, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
fixdiv.diff jayvdb, 2015-10-29 06:37 Fix review
fixdiv-remove-truncate.diff jayvdb, 2015-10-29 06:38 Remove truncate review
Messages (2)
msg253661 - (view) Author: John Mark Vandenberg (jayvdb) * Date: 2015-10-29 06:37
Tools/scripts/fixdiv.py 's `FileContext.truncate` has used `window` since it was created, when it is supposed to use self.window.

https://hg.python.org/cpython/annotate/60f290a7eae8/Tools/scripts/fixdiv.py#l195

`truncate` is unused, so an alternative fix is to remove it, as it has never worked, and nobody has complained.
msg253769 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-10-30 23:26
New changeset 2672ab3cfb23 by Terry Jan Reedy in branch '2.7':
Issue #25505: Remove unused buggy method.
https://hg.python.org/cpython/rev/2672ab3cfb23

New changeset ef435729bc80 by Terry Jan Reedy in branch '3.4':
Issue #25505: Remove unused buggy method.
https://hg.python.org/cpython/rev/ef435729bc80
History
Date User Action Args
2022-04-11 14:58:23adminsetgithub: 69691
2015-10-30 23:28:00terry.reedysetstatus: open -> closed
type: behavior
resolution: fixed
stage: resolved
2015-10-30 23:26:26python-devsetnosy: + python-dev
messages: + msg253769
2015-10-30 23:20:38terry.reedysetassignee: terry.reedy

nosy: + terry.reedy
2015-10-29 08:01:08jayvdbsetnosy: + serhiy.storchaka
2015-10-29 06:38:47jayvdbsetfiles: + fixdiv-remove-truncate.diff
2015-10-29 06:37:50jayvdbcreate