This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: In threading module, use with instead of try finally
Type: Stage: resolved
Components: Library (Lib) Versions: Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: nirs, python-dev
Priority: normal Keywords: patch

Created on 2015-10-10 14:37 by nirs, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
0001-Use-with-instead-of-try-finally.patch nirs, 2015-10-10 14:37 Patch for master
0001-In-threading-module-use-with-instead-of-try-finally.patch nirs, 2015-10-10 15:08 Improved commit message
Messages (2)
msg252716 - (view) Author: Nir Soffer (nirs) * Date: 2015-10-10 14:37
Using "with" is more clear and less error prone.
msg252752 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-10-11 02:37
New changeset 9049134eecae by Benjamin Peterson in branch '2.7':
use the with statement for locking the internal condition (closes #25362)
https://hg.python.org/cpython/rev/9049134eecae

New changeset 62e87422a1a9 by Benjamin Peterson in branch '3.4':
use the with statement for locking the internal condition (closes #25362)
https://hg.python.org/cpython/rev/62e87422a1a9

New changeset 794101c6e560 by Benjamin Peterson in branch '3.5':
merge 3.4 (#25362)
https://hg.python.org/cpython/rev/794101c6e560

New changeset 555ab69f071a by Benjamin Peterson in branch 'default':
merge 3.5 (#25362)
https://hg.python.org/cpython/rev/555ab69f071a
History
Date User Action Args
2022-04-11 14:58:22adminsetgithub: 69549
2015-10-11 02:37:07python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg252752

resolution: fixed
stage: resolved
2015-10-10 15:08:38nirssetfiles: + 0001-In-threading-module-use-with-instead-of-try-finally.patch
2015-10-10 14:53:25eric.smithsettitle: Use with instead of try finally -> In threading module, use with instead of try finally
2015-10-10 14:37:40nirscreate