Created on 2015-07-27 11:19 by skrah, last changed 2015-08-17 05:22 by Arfrever. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| itertools_invalid_access.diff | skrah, 2015-07-27 11:19 | review | ||
| Messages (5) | |||
|---|---|---|---|
| msg247460 - (view) | Author: Stefan Krah (skrah) *  |
Date: 2015-07-27 11:19 | |
There's a corner case in cwr_next(), where the pool size is zero but pool[0] is accessed: from itertools import * it = combinations_with_replacement([], 0) next(it) Patch attached. |
|||
| msg247509 - (view) | Author: Roundup Robot (python-dev) | Date: 2015-07-28 09:08 | |
New changeset fd3fb122c5ff by Raymond Hettinger in branch '3.4': Issue #24735: Fix invalid memory access in combinations_with_replacement() https://hg.python.org/cpython/rev/fd3fb122c5ff |
|||
| msg247512 - (view) | Author: STINNER Victor (haypo) * |
Date: 2015-07-28 09:31 | |
Can someone please write an unit test to avoid regressions in the future? |
|||
| msg247513 - (view) | Author: Stefan Krah (skrah) * |
Date: 2015-07-28 10:32 | |
Victor, there was no actual crash, just a potential one. In terms of the observable runtime behavior the code behaved correctly. I would not know what to test for, unless we set up a buildbot running Valgrind (which is impracticable for a number of reasons). |
|||
| msg247514 - (view) | Author: STINNER Victor (haypo) * |
Date: 2015-07-28 10:34 | |
Oh I see. Ok, since it's a corner case, I'm fine with no unit test. Thanks for the report Stefan, and thanks for the fix Raymond ;-) |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2015-08-17 05:22:28 | Arfrever | set | nosy:
+ Arfrever |
| 2015-07-28 11:33:42 | berker.peksag | set | stage: patch review -> resolved |
| 2015-07-28 10:34:03 | haypo | set | status: open -> closed resolution: fixed messages: + msg247514 |
| 2015-07-28 10:32:08 | skrah | set | messages: + msg247513 |
| 2015-07-28 09:31:49 | haypo | set | status: closed -> open nosy: + haypo messages: + msg247512 resolution: fixed -> (no value) |
| 2015-07-28 09:10:11 | rhettinger | set | status: open -> closed resolution: fixed |
| 2015-07-28 09:08:31 | python-dev | set | nosy:
+ python-dev messages: + msg247509 |
| 2015-07-28 08:29:04 | rhettinger | set | messages: - msg247505 |
| 2015-07-28 08:04:23 | rhettinger | set | messages: + msg247505 |
| 2015-07-28 07:57:52 | rhettinger | set | assignee: rhettinger |
| 2015-07-27 12:06:44 | serhiy.storchaka | set | nosy:
+ serhiy.storchaka stage: patch review |
| 2015-07-27 11:19:58 | skrah | create | |