This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Build fails when threads are disabled
Type: compile error Stage: resolved
Components: Interpreter Core Versions: Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: berker.peksag, louis.dassy, python-dev
Priority: normal Keywords: patch

Created on 2015-07-26 15:02 by louis.dassy, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
without_threads.patch louis.dassy, 2015-07-26 15:02 review
Messages (3)
msg247430 - (view) Author: Louis Dassy (louis.dassy) * Date: 2015-07-26 15:02
If threads are disabled using --without-threads, the build of  Python/pythonrun.c will fail because PyGILState_GetThisThreadState() is undefined. I've attached the trivial fix, modeled after 29f51c4ae11a.
msg247467 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-07-27 13:49
New changeset d10f7e0cd059 by Berker Peksag in branch '3.4':
Issue #24728: Fix building without threads.
https://hg.python.org/cpython/rev/d10f7e0cd059

New changeset 401bb7ceb7e8 by Berker Peksag in branch '3.5':
Issue #24728: Null merge
https://hg.python.org/cpython/rev/401bb7ceb7e8

New changeset 752b59a9b9cd by Berker Peksag in branch 'default':
Issue #24728: Null merge
https://hg.python.org/cpython/rev/752b59a9b9cd
msg247468 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2015-07-27 13:53
Thanks Louis. If you are going to continue contributing patches, please sign the PSF Contribution Agreement: https://www.python.org/psf/contrib/contrib-form/
History
Date User Action Args
2022-04-11 14:58:19adminsetgithub: 68916
2015-07-27 13:53:55berker.peksagsetstatus: open -> closed

nosy: + berker.peksag
messages: + msg247468

resolution: fixed
stage: resolved
2015-07-27 13:49:20python-devsetnosy: + python-dev
messages: + msg247467
2015-07-26 15:02:48louis.dassycreate