This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: xxlimited.c errors when building 32 and 64 bit on Windows
Type: compile error Stage: resolved
Components: Windows Versions: Python 3.6, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: steve.dower Nosy List: BreamoreBoy, python-dev, r.david.murray, steve.dower, tim.golden, zach.ware
Priority: normal Keywords:

Created on 2015-06-03 15:53 by BreamoreBoy, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (11)
msg244764 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2015-06-03 15:53
5>..\Modules\xxlimited.c(268): error C2061: syntax error : identifier 'xx_slots'
5>..\Modules\xxlimited.c(268): error C2059: syntax error : ';'
5>..\Modules\xxlimited.c(268): error C3409: empty attribute block is not allowed
5>..\Modules\xxlimited.c(268): error C2513: '/*global*/ ' : no variable declared before '='
5>..\Modules\xxlimited.c(269): error C2065: 'Py_mod_exec' : undeclared identifier
5>..\Modules\xxlimited.c(279): error C2065: 'xx_slots' : undeclared identifier
5>..\Modules\xxlimited.c(283): error C2099: initializer is not a constant
5>..\Modules\xxlimited.c(290): warning C4013: 'PyModuleDef_Init' undefined; assuming extern returning int
5>..\Modules\xxlimited.c(290): warning C4047: 'return' : 'PyObject *' differs in levels of indirection from 'int'

I believe it's down to r46496.
msg244765 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2015-06-03 16:16
Which revision? Can you post a hash or issue number instead - in my repo r46496 is from a couple of years ago...
msg244766 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2015-06-03 16:21
Try r96496 :(
msg244770 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2015-06-03 16:34
It's more recent, but still only a doc change.

What's the description of the change you're referring to?
msg244771 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2015-06-03 16:45
Following taken from tortoisehg workbench, the only file changed is setup.py so please don't ask.

Changeset: 96496 (6278f932fb29) upgrade xxlimited abi to 3.5
Branch:  3.5 
User: Benjamin Peterson <benjamin@python.org>
Date: 2015-06-03 00:04:46 -0500 (11 hours)
Parent: 96494 (38ffea158630) Issue #24368: Support keyword arguments in OrderedDict methods.
Child: 96497 (6278231825a1)  default  merge 3.5
msg244780 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2015-06-03 17:55
We need to bump the Py_LIMITED_API definition in PCbuild/xxlimited.vcxproj
as well.
msg244781 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-06-03 18:05
New changeset b8bcc5507541 by Steve Dower in branch '3.5':
Issue #24376: xxlimited.c errors when building 32 and 64 bit on Windows
https://hg.python.org/cpython/rev/b8bcc5507541

New changeset c802fba79554 by Steve Dower in branch 'default':
Issue #24376: xxlimited.c errors when building 32 and 64 bit on Windows
https://hg.python.org/cpython/rev/c802fba79554
msg244782 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-06-03 18:06
New changeset 31301b84ac8d by Steve Dower in branch 'default':
Issue #24376: Bumps xxlimited.vcxproj to use 3.6 limited ABI.
https://hg.python.org/cpython/rev/31301b84ac8d
msg244783 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2015-06-03 18:25
Mark, FYI the 'r' numbers are unique to each mercurial checkout and meaningless to anyone else.  Only the hash numbers can be used to compare revisions between different repositories.  (You *could* refer to the r number from the cpython repository as seen in the mercurial web interface to it, because other people could look that one up via the web interface, but it is best to get in the habit of always using the hash.)
msg244787 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2015-06-03 20:00
Thanks for the comment David.  Last time I used any kind of change system in anger was Visual Source Safe 15 years ago, and VAX/VMS CMS/MMF(?) before that.  Where do I start with Mercurial?  I don't even know what the difference is between setting up the now default 3.6 and 3.5?
msg244836 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2015-06-04 17:22
Now compiles, thanks guys :)
History
Date User Action Args
2022-04-11 14:58:17adminsetgithub: 68564
2015-06-05 03:47:21zach.waresetstatus: open -> closed
assignee: steve.dower
resolution: fixed
stage: resolved
2015-06-04 17:22:55BreamoreBoysetmessages: + msg244836
2015-06-03 20:00:13BreamoreBoysetmessages: + msg244787
2015-06-03 18:25:09r.david.murraysetnosy: + r.david.murray
messages: + msg244783
2015-06-03 18:06:13python-devsetmessages: + msg244782
2015-06-03 18:05:07python-devsetnosy: + python-dev
messages: + msg244781
2015-06-03 17:55:26zach.waresetmessages: + msg244780
2015-06-03 16:45:01BreamoreBoysetmessages: + msg244771
2015-06-03 16:34:54steve.dowersetmessages: + msg244770
2015-06-03 16:21:17BreamoreBoysetmessages: + msg244766
2015-06-03 16:16:40steve.dowersetmessages: + msg244765
2015-06-03 15:53:47BreamoreBoycreate