➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2015-03-01 05:59 by gc, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 9859 | merged | python-dev, 2018-10-13 23:46 | |
| PR 9900 | merged | miss-islington, 2018-10-15 21:39 | |
| Messages (7) | |||
|---|---|---|---|
| msg236932 - (view) | Author: Giovanni Cannata (gc) | Date: 2015-03-01 05:59 | |
In 18.5.4.3.2. TCP echo server protocol the class in the example code is called EchoServerClientProtocol. It should be EchoServerProtocol. (The client protocol example is correctly called EchoClientProtocol). |
|||
| msg327614 - (view) | Author: Cheryl Sabella (cheryl.sabella) *  |
Date: 2018-10-12 22:09 | |
Here's a link to the example that the original OP is referring to: https://docs.python.org/3/library/asyncio-protocol.html?highlight=echoserverclientprotocol#tcp-echo-server Since this doc page was recently rewritten, I'm not sure if this should be considered a typo. |
|||
| msg327615 - (view) | Author: Andrew Svetlov (asvetlov) * |
Date: 2018-10-12 22:17 | |
Agree, EchoServer is the better name |
|||
| msg327616 - (view) | Author: Cheryl Sabella (cheryl.sabella) * |
Date: 2018-10-12 23:00 | |
Thanks @asvetlov. I'm going to mark this as an Easy Documentation issue, good for a first-time contributor. |
|||
| msg327617 - (view) | Author: Andrew Svetlov (asvetlov) * |
Date: 2018-10-12 23:50 | |
Cool! Thanks! |
|||
| msg327790 - (view) | Author: Yury Selivanov (yselivanov) * |
Date: 2018-10-15 21:39 | |
New changeset 43a5bd7b458f0ad2d62b00b033d025689d48d591 by Yury Selivanov (Braden Groom) in branch 'master': bpo-23554: Change echo server example class name from EchoServerClientProtocol to EchoServerProtocol (GH-9859) https://github.com/python/cpython/commit/43a5bd7b458f0ad2d62b00b033d025689d48d591 |
|||
| msg327795 - (view) | Author: miss-islington (miss-islington) | Date: 2018-10-15 21:59 | |
New changeset 802de12d99d16e621537d454eac942d2f448afee by Miss Islington (bot) in branch '3.7': bpo-23554: Change echo server example class name from EchoServerClientProtocol to EchoServerProtocol (GH-9859) https://github.com/python/cpython/commit/802de12d99d16e621537d454eac942d2f448afee |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:13 | admin | set | github: 67742 |
| 2018-10-15 21:59:55 | miss-islington | set | nosy:
+ miss-islington messages: + msg327795 |
| 2018-10-15 21:40:26 | yselivanov | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2018-10-15 21:39:28 | miss-islington | set | pull_requests: + pull_request9262 |
| 2018-10-15 21:39:20 | yselivanov | set | messages: + msg327790 |
| 2018-10-13 23:46:53 | python-dev | set | keywords:
+ patch stage: needs patch -> patch review pull_requests: + pull_request9227 |
| 2018-10-12 23:50:11 | asvetlov | set | messages: + msg327617 |
| 2018-10-12 23:00:22 | cheryl.sabella | set | keywords:
+ easy type: enhancement messages: + msg327616 stage: needs patch |
| 2018-10-12 22:17:34 | asvetlov | set | nosy:
+ asvetlov messages: + msg327615 |
| 2018-10-12 22:09:55 | cheryl.sabella | set | nosy:
+ cheryl.sabella, yselivanov messages: + msg327614 versions: + Python 3.8, - Python 3.4 |
| 2015-03-01 05:59:32 | gc | create | |