➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2015-02-03 08:42 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| bytes_format.patch | serhiy.storchaka, 2015-02-03 08:42 | review | ||
| bytes_format_2.patch | serhiy.storchaka, 2015-02-04 08:17 | review | ||
| bytes_format_3.patch | serhiy.storchaka, 2015-02-10 21:10 | review | ||
| Messages (8) | |||
|---|---|---|---|
| msg235320 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2015-02-03 08:42 | |
Proposed patch makes following changes to bytes formatting code: 1) Fixes a bug when PyUnicode_AsEncodedObject() returns non-bytes byte-like object. 2) Avoid few non-neccessary memory allocations and copyings (converting bytearray or ASCII string to bytes). 3) Clean up the code. |
|||
| msg235382 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2015-02-04 08:17 | |
Thanks to Martin's suggestions here is even more clean patch. |
|||
| msg235701 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2015-02-10 20:10 | |
Ping. |
|||
| msg235704 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2015-02-10 20:57 | |
Updated patch addresses Victor's comments. |
|||
| msg235706 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2015-02-10 21:10 | |
Eliminated tabs. |
|||
| msg235707 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2015-02-10 21:18 | |
Thank you for your reviews and suggestions Martin and Victor. If Ethan has no objections I'll commit the patch soon. |
|||
| msg235708 - (view) | Author: Ethan Furman (ethan.furman) * |
Date: 2015-02-10 21:20 | |
As long as it works I have no objections. :) |
|||
| msg235709 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2015-02-10 21:23 | |
New changeset 4883f9046b10 by Serhiy Storchaka in branch 'default': Issue #23383: Cleaned up bytes formatting. https://hg.python.org/cpython/rev/4883f9046b10 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:12 | admin | set | github: 67572 |
| 2015-02-12 13:24:05 | serhiy.storchaka | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2015-02-10 21:23:48 | python-dev | set | messages: + msg235709 |
| 2015-02-10 21:20:34 | ethan.furman | set | messages: + msg235708 |
| 2015-02-10 21:18:08 | serhiy.storchaka | set | assignee: serhiy.storchaka messages: + msg235707 |
| 2015-02-10 21:10:56 | serhiy.storchaka | set | files:
+ bytes_format_3.patch messages: + msg235706 |
| 2015-02-10 21:10:28 | serhiy.storchaka | set | files: - bytes_format_3.patch |
| 2015-02-10 20:57:43 | serhiy.storchaka | set | files:
+ bytes_format_3.patch messages: + msg235704 |
| 2015-02-10 20:10:30 | serhiy.storchaka | set | messages: + msg235701 |
| 2015-02-04 08:17:41 | serhiy.storchaka | set | files:
+ bytes_format_2.patch messages: + msg235382 |
| 2015-02-03 08:42:53 | serhiy.storchaka | create | |