➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2014-06-18 19:00 by pitrou, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| complex_macros.patch | pitrou, 2014-06-18 19:00 | review | ||
| Messages (7) | |||
|---|---|---|---|
| msg220947 - (view) | Author: Antoine Pitrou (pitrou) *  |
Date: 2014-06-18 19:00 | |
I thought this would make things less confusing to read. |
|||
| msg222437 - (view) | Author: Mark Dickinson (mark.dickinson) * |
Date: 2014-07-07 07:08 | |
LGTM. |
|||
| msg222532 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2014-07-07 22:50 | |
New changeset 9f75a29c9577 by Antoine Pitrou in branch 'default': Issue #21803: remove macro indirections in complexobject.h http://hg.python.org/cpython/rev/9f75a29c9577 |
|||
| msg222533 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2014-07-07 22:50 | |
Ok, pushed. |
|||
| msg222535 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2014-07-07 23:04 | |
Failure on buildbot. http://buildbot.python.org/all/builders/AMD64%20Ubuntu%20LTS%203.x/builds/4599/steps/test/logs/stdio running build_ext building 'cmath' extension gcc -pthread -fPIC -Wno-unused-result -Werror=declaration-after-statement -g -O0 -Wall -Wstrict-prototypes -I./Include -I. -IInclude -I/usr/include/x86_64-linux-gnu -I/usr/local/include -I/opt/python/3.x.langa-ubuntu/build/Include -I/opt/python/3.x.langa-ubuntu/build -c /opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.c -o build/temp.linux-x86_64-3.5-pydebug/opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.o /opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.c: In function ‘c_atanh’: /opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.c:316:9: warning: implicit declaration of function ‘c_neg’ [-Wimplicit-function-declaration] /opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.c:316:9: error: incompatible type for argument 1 of ‘c_atanh’ /opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.c:307:1: note: expected ‘Py_complex’ but argument is of type ‘int’ /opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.c: In function ‘cmath_log’: /opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.c:845:9: warning: implicit declaration of function ‘c_quot’ [-Wimplicit-function-declaration] /opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.c:845:11: error: incompatible types when assigning to type ‘Py_complex’ from type ‘int’ /opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.c: In function ‘cmath_polar’: /opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.c:946:5: warning: implicit declaration of function ‘c_abs’ [-Wimplicit-function-declaration] Failed to build these modules: cmath |
|||
| msg222536 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2014-07-07 23:08 | |
Ha, I hadn't noticed the compilation failures when rebuilding... |
|||
| msg222537 - (view) | Author: Roundup Robot (python-dev) |
Date: 2014-07-07 23:08 | |
New changeset 4609e31092b2 by Antoine Pitrou in branch 'default': Fix compilation failure (followup to #21803) http://hg.python.org/cpython/rev/4609e31092b2 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:05 | admin | set | github: 66002 |
| 2014-07-07 23:44:24 | pitrou | set | status: open -> closed resolution: fixed |
| 2014-07-07 23:08:56 | python-dev | set | messages: + msg222537 |
| 2014-07-07 23:08:30 | pitrou | set | messages: + msg222536 |
| 2014-07-07 23:04:39 | vstinner | set | status: closed -> open nosy: + vstinner messages: + msg222535 resolution: fixed -> (no value) |
| 2014-07-07 22:50:31 | pitrou | set | status: open -> closed resolution: fixed messages: + msg222533 stage: patch review -> resolved |
| 2014-07-07 22:50:02 | python-dev | set | nosy:
+ python-dev messages: + msg222532 |
| 2014-07-07 07:08:18 | mark.dickinson | set | messages: + msg222437 |
| 2014-06-18 19:00:51 | pitrou | create | |