This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Shallow defaults to True, not 1 [filecmp.cmp]
Type: behavior Stage: resolved
Components: Library (Lib) Versions: Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: diana, python-dev
Priority: normal Keywords: patch

Created on 2014-04-26 12:46 by diana, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
shallow_defaults_to_true_not_1.patch diana, 2014-04-26 12:46 review
Messages (2)
msg217192 - (view) Author: diana (diana) * Date: 2014-04-26 12:46
A minor correction to the filecmp.cmp doc string.

    'defaults to 1' -> 'defaults to True'

While shallow used to default to 1 years ago, it now defaults to True.

    def cmp(f1, f2, shallow=True):

PS. I know this diff is annoyingly trivial, but I'm using it to learn the process.

Thanks,

--diana
msg217205 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-04-26 17:36
New changeset b7fd640fb159 by Benjamin Peterson in branch '3.4':
shallow defaults to 'True' not '1' (closes #21355)
http://hg.python.org/cpython/rev/b7fd640fb159

New changeset 9ab6d13553ef by Benjamin Peterson in branch 'default':
merge 3.4 (#21355)
http://hg.python.org/cpython/rev/9ab6d13553ef
History
Date User Action Args
2022-04-11 14:58:02adminsetgithub: 65554
2014-04-26 17:36:42python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg217205

resolution: fixed
stage: resolved
2014-04-26 12:47:39dianasettitle: shallow defaults to true, not 1 [filecmp.cmp] -> Shallow defaults to True, not 1 [filecmp.cmp]
2014-04-26 12:46:33dianacreate