➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2014-04-01 22:22 by mattip, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| patch | mattip, 2014-04-01 22:22 | hg patch | ||
| patch | mattip, 2014-04-03 19:51 | patch against 2.7 | ||
| patch | mattip, 2014-04-04 08:29 | patch to version 03df2c1c6892 | review | |
| Messages (6) | |||
|---|---|---|---|
| msg215343 - (view) | Author: mattip (mattip) * | Date: 2014-04-01 22:22 | |
In continuation of issue 20887, this patch closes and removes all temp files created while running regression tests for stdlib 2.7.6 on win32 and pypy. Note that a gc.collect was required to release the closed files in test_argparse, as well as making them all rw. |
|||
| msg215462 - (view) | Author: mattip (mattip) * | Date: 2014-04-03 19:51 | |
the gc.collect is not needed, sorry. I updated the patch, which affects test_argparse.py (make files rw before rmtree) test_file.py (add file.close() ) test_file2k.py (add file.close() ) test_httpservers.py (add file.close() ) |
|||
| msg215478 - (view) | Author: Benjamin Peterson (benjamin.peterson) *  |
Date: 2014-04-03 22:46 | |
This patch appears to have been generated against a pypy checkout rather than a cpython checkout. |
|||
| msg215502 - (view) | Author: mattip (mattip) * | Date: 2014-04-04 08:29 | |
Correct, the other patches were against pypy, sorry. I now patched and tested against banch 2.7 on the python tree. |
|||
| msg215506 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2014-04-04 09:40 | |
I'm wondering why resource warnings are not raised in CPython?
./python -Werror -bb -m test.regrtest -uall test_argparse test_file test_httpservers
|
|||
| msg215545 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2014-04-04 18:00 | |
New changeset b56341a49eab by Benjamin Peterson in branch '2.7': make temporary read-only files writable, so rmtree can remove them (#21128) http://hg.python.org/cpython/rev/b56341a49eab New changeset 6f1ac58207cc by Benjamin Peterson in branch '2.7': properly explicitly close file (#21128) http://hg.python.org/cpython/rev/6f1ac58207cc New changeset d7a37a1f2ca9 by Benjamin Peterson in branch '2.7': explicitly close file object (#21128) http://hg.python.org/cpython/rev/d7a37a1f2ca9 New changeset 9fd33a504b58 by Benjamin Peterson in branch '3.4': make temporary read-only files writable, so rmtree can remove them (#21128) http://hg.python.org/cpython/rev/9fd33a504b58 New changeset 78e75181d87f by Benjamin Peterson in branch 'default': merge 3.4 (#21128) http://hg.python.org/cpython/rev/78e75181d87f |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:01 | admin | set | github: 65327 |
| 2014-04-04 18:01:27 | benjamin.peterson | set | status: open -> closed resolution: fixed |
| 2014-04-04 18:00:06 | python-dev | set | nosy:
+ python-dev messages: + msg215545 |
| 2014-04-04 09:40:09 | serhiy.storchaka | set | messages: + msg215506 |
| 2014-04-04 08:29:06 | mattip | set | files:
+ patch messages: + msg215502 |
| 2014-04-03 22:46:06 | benjamin.peterson | set | nosy:
+ benjamin.peterson messages: + msg215478 |
| 2014-04-03 19:51:54 | mattip | set | files:
+ patch messages: + msg215462 |
| 2014-04-02 13:49:09 | brett.cannon | set | nosy:
+ brett.cannon |
| 2014-04-02 01:31:42 | ned.deily | set | keywords:
+ patch nosy: + serhiy.storchaka stage: patch review |
| 2014-04-01 22:22:57 | mattip | create | |