This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: macro SET_SYS_FROM_STRING_BORROW doesn't get unset
Type: Stage: resolved
Components: Versions: Python 3.4, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: brett.cannon, eric.snow, python-dev
Priority: low Keywords:

Created on 2014-03-28 20:19 by eric.snow, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (3)
msg215075 - (view) Author: Eric Snow (eric.snow) * (Python committer) Date: 2014-03-28 20:19
In Python/sysmodule.c (_PySys_Init), the SET_SYS_FROM_STRING_BORROW macro is created right next to SET_SYS_FROM_STRING.  However, while SET_SYS_FROM_STRING is unset at the end of _PySys_Init,  SET_SYS_FROM_STRING_BORROW is not unset.  I expect that it should be.

 #endif

 #undef SET_SYS_FROM_STRING
+#undef SET_SYS_FROM_STRING_BORROW
     if (PyErr_Occurred())
msg215089 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-03-28 22:55
New changeset c88a7c38eb0d by Benjamin Peterson in branch '3.4':
undefine SET_SYS_FROM_STRING_BORROW after its done being used (closes #21089)
http://hg.python.org/cpython/rev/c88a7c38eb0d

New changeset c73b71363d4c by Benjamin Peterson in branch 'default':
merge 3.4 (#21089)
http://hg.python.org/cpython/rev/c73b71363d4c
msg215094 - (view) Author: Eric Snow (eric.snow) * (Python committer) Date: 2014-03-28 23:35
Thanks, Benjamin.
History
Date User Action Args
2022-04-11 14:58:00adminsetgithub: 65288
2014-03-28 23:35:31eric.snowsetmessages: + msg215094
2014-03-28 22:55:29python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg215089

resolution: fixed
stage: needs patch -> resolved
2014-03-28 20:19:14eric.snowcreate