➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2014-03-25 23:13 by pitrou, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| sslproto_enum.patch | pitrou, 2014-03-25 23:13 | review | ||
| Messages (10) | |||
|---|---|---|---|
| msg214865 - (view) | Author: Antoine Pitrou (pitrou) *  |
Date: 2014-03-25 23:13 | |
Small patch to make PROTOCOL_SSLv23 and friends enum members. Not sure this is useful. |
|||
| msg214868 - (view) | Author: Donald Stufft (dstufft) * |
Date: 2014-03-25 23:31 | |
I don't really feel real strongly one way or another about this patch fwiw. Not sure it makes anything easier but I don't think it makes anything harder either. |
|||
| msg214869 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2014-03-25 23:32 | |
It may be useful in relation with issue20421, since we could then return one of the enum values (not PROTOCOL_SSLv23, of course). |
|||
| msg214870 - (view) | Author: Donald Stufft (dstufft) * |
Date: 2014-03-25 23:33 | |
Ah, sure it'd probably be useful in that context. |
|||
| msg214872 - (view) | Author: Giampaolo Rodola' (giampaolo.rodola) * |
Date: 2014-03-25 23:51 | |
I like this. Possibly it should be done for all ssl APIs returning a constant. Are there others? |
|||
| msg215071 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2014-03-28 19:38 | |
> Possibly it should be done for all ssl APIs returning a constant. Are there others? There's SSLContext.verify_mode, but it simply mirrors the configuration chosen by the user. |
|||
| msg216517 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2014-04-16 17:49 | |
Anyone else has an opinion on this? |
|||
| msg216540 - (view) | Author: Ethan Furman (ethan.furman) * |
Date: 2014-04-16 18:20 | |
Looks good to me. |
|||
| msg216790 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2014-04-18 18:33 | |
New changeset f776771ab0ee by Antoine Pitrou in branch 'default': Issue #21068: The ssl.PROTOCOL* constants are now enum members. http://hg.python.org/cpython/rev/f776771ab0ee |
|||
| msg216791 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2014-04-18 18:39 | |
Ok, since this is a low-risk change I've made it anyway. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:00 | admin | set | github: 65267 |
| 2014-04-18 18:39:14 | pitrou | set | status: open -> closed resolution: fixed messages: + msg216791 stage: patch review -> resolved |
| 2014-04-18 18:33:14 | python-dev | set | nosy:
+ python-dev messages: + msg216790 |
| 2014-04-16 18:20:58 | ethan.furman | set | messages: + msg216540 |
| 2014-04-16 17:49:44 | pitrou | set | messages: + msg216517 |
| 2014-03-28 19:38:10 | pitrou | set | messages: + msg215071 |
| 2014-03-25 23:51:26 | giampaolo.rodola | set | messages: + msg214872 |
| 2014-03-25 23:33:12 | dstufft | set | messages: + msg214870 |
| 2014-03-25 23:32:29 | pitrou | set | messages: + msg214869 |
| 2014-03-25 23:31:28 | dstufft | set | messages: + msg214868 |
| 2014-03-25 23:26:17 | ethan.furman | set | nosy:
+ ethan.furman |
| 2014-03-25 23:13:47 | pitrou | create | |