This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_smptnet Fail instead of Skip if SSL-port is unavailable
Type: behavior Stage:
Components: Tests Versions: Python 3.4, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: BreamoreBoy, ebfe, python-dev, vstinner
Priority: normal Keywords: patch

Created on 2014-03-17 12:56 by ebfe, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test_smptnet.txt ebfe, 2014-03-17 12:56 log
cpython_hg_89810_to_89811.diff ebfe, 2014-03-17 12:58 review
Messages (5)
msg213855 - (view) Author: Lukas Lueg (ebfe) Date: 2014-03-17 12:56
If the SSL-port is unavailable due to firewall settings (or the host simply being down), the SSL-tests in test_smtpnet.py fail instead of being skipped.

The tests should be skipped if the smtp.google.com can't be reached and fail only in case of unexpected behaviour.
msg213857 - (view) Author: Lukas Lueg (ebfe) Date: 2014-03-17 12:58
Diff the make test_smtpnet pass if the network-resource is available but smtp.google.com's ssl-port can't be reached. Most probably there is a better way to do this.
msg221025 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2014-06-19 21:31
Can somebody review the attached patch please.
msg226331 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-09-03 22:36
New changeset b7200cde1b68 by Victor Stinner in branch '3.4':
Issue #20957: test_smtpnet now uses support.transient_internet() to call
http://hg.python.org/cpython/rev/b7200cde1b68

New changeset 85511d4a846e by Victor Stinner in branch 'default':
(Merge 3.4) Issue #20957: test_smtpnet now uses support.transient_internet() to
http://hg.python.org/cpython/rev/85511d4a846e
msg226332 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2014-09-03 22:37
Thanks for the report. I wrote a different patch to rely on  support.transient_internet() instead.
History
Date User Action Args
2022-04-11 14:58:00adminsetgithub: 65156
2014-09-03 22:37:42vstinnersetstatus: open -> closed
versions: + Python 3.5
nosy: + vstinner

messages: + msg226332

resolution: fixed
2014-09-03 22:36:26python-devsetnosy: + python-dev
messages: + msg226331
2014-06-19 21:31:43BreamoreBoysetnosy: + BreamoreBoy
messages: + msg221025
2014-03-17 12:58:06ebfesetfiles: + cpython_hg_89810_to_89811.diff
keywords: + patch
messages: + msg213857
2014-03-17 12:56:05ebfecreate