This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_asyncio: test_create_server() failed on "x86 Windows Server 2008 [SB] 3.x"
Type: Stage:
Components: Tests Versions: Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: gvanrossum, python-dev, sbt, vstinner
Priority: normal Keywords: buildbot

Created on 2013-11-25 09:29 by vstinner, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (5)
msg204315 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2013-11-25 09:29
http://buildbot.python.org/all/builders/x86%20Windows%20Server%202008%20%5BSB%5D%203.x/builds/1794/steps/test/logs/stdio

======================================================================
FAIL: test_create_server (test.test_asyncio.test_events.ProactorEventLoopTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "E:\home\cpython\buildslave\x86\3.x.snakebite-win2k8r2sp1-x86\build\lib\test\test_asyncio\test_events.py", line 563, in test_create_server
    self.assertIsInstance(proto, MyProto)
AssertionError: None is not an instance of <class 'test.test_asyncio.test_events.MyProto'>

----------------------------------------------------------------------
msg204352 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2013-11-25 15:49
Can you try this fix?

diff -r 8d0206f97439 Lib/test/test_asyncio/test_events.py
--- a/Lib/test/test_asyncio/test_events.py      Sun Nov 24 22:41:35 2013 -0800
+++ b/Lib/test/test_asyncio/test_events.py      Mon Nov 25 07:48:29 2013 -0800
@@ -559,7 +559,7 @@
         client = socket.socket()
         client.connect(('127.0.0.1', port))
         client.sendall(b'xxx')
-        test_utils.run_briefly(self.loop)
+        test_utils.run_until(self.loop, lambda: proto is not None, 10)
         self.assertIsInstance(proto, MyProto)
         self.assertEqual('INITIAL', proto.state)
         test_utils.run_briefly(self.loop)

(I can also just commit that and the test_unix_events.py fix for AIX and hope for the best.)
msg204357 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2013-11-25 16:38
> Can you try this fix?

If you are asking to me: again, I don't own a Windows 2008 copy. Just commit and then watch buildbots :-)
msg204375 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-11-25 18:06
New changeset 368b74823c76 by Guido van Rossum in branch 'default':
asyncio: Hopeful fix for issue 19765.
http://hg.python.org/cpython/rev/368b74823c76
msg204635 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2013-11-28 01:27
I didn't see the failure recently, so I hope that it was fixed. I close the issue. I will reopen it if I see the failure again.

Thanks Guido for your fix.
History
Date User Action Args
2022-04-11 14:57:54adminsetgithub: 63964
2013-11-28 01:27:09vstinnersetstatus: open -> closed
resolution: fixed
messages: + msg204635
2013-11-25 18:06:44python-devsetnosy: + python-dev
messages: + msg204375
2013-11-25 17:04:04pitrousetnosy: + sbt
2013-11-25 16:38:33vstinnersetmessages: + msg204357
2013-11-25 15:49:31gvanrossumsetmessages: + msg204352
2013-11-25 09:29:26vstinnercreate