This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: No unit test for iso2time function from http.cookiejar module
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.3, Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ezio.melotti Nosy List: belopolsky, berker.peksag, ezio.melotti, python-dev, terry.reedy, vajrasky
Priority: normal Keywords:

Created on 2013-07-17 16:37 by vajrasky, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
add_iso2time_test.txt vajrasky, 2013-07-17 16:37 Unit test for iso2time review
Messages (4)
msg193241 - (view) Author: Vajrasky Kok (vajrasky) * Date: 2013-07-17 16:37
From http.cookiejar module, we have http2time and iso2time functions.

We have unit test for http2time, but not for iso2time. That's not fair.

Attached the extended coverage test for iso2time function.
msg193383 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2013-07-19 22:03
Alexander, I added you for possible review because of your interest in time functions. I wonder a bit if this function is redundant with functions in other modules.
msg194801 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-08-10 15:21
New changeset fe5d105eba4b by Ezio Melotti in branch '3.3':
#18484: improve test coverage of http.cookiejar.  Patch by Vajrasky Kok.
http://hg.python.org/cpython/rev/fe5d105eba4b

New changeset 7bf1f8892df5 by Ezio Melotti in branch 'default':
#18484: merge with 3.3.
http://hg.python.org/cpython/rev/7bf1f8892df5
msg194802 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2013-08-10 15:22
Fixed, thanks for the patch!
History
Date User Action Args
2022-04-11 14:57:48adminsetgithub: 62684
2013-08-10 15:22:20ezio.melottisetstatus: open -> closed

type: enhancement
assignee: ezio.melotti
versions: + Python 3.3
nosy: + ezio.melotti

messages: + msg194802
resolution: fixed
stage: patch review -> resolved
2013-08-10 15:21:20python-devsetnosy: + python-dev
messages: + msg194801
2013-08-04 16:52:25berker.peksagsetnosy: + berker.peksag
2013-07-19 22:03:36terry.reedysetnosy: + terry.reedy, belopolsky

messages: + msg193383
stage: patch review
2013-07-17 16:37:57vajraskycreate