This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Add hour-24 type of time to test_http2time_formats in test_http_cookiejar.py
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.3, Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ezio.melotti Nosy List: ezio.melotti, python-dev, vajrasky
Priority: normal Keywords:

Created on 2013-07-17 15:50 by vajrasky, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
add_hour_24_in_test_http2time_format.txt vajrasky, 2013-07-17 15:50 review
Messages (3)
msg193236 - (view) Author: Vajrasky Kok (vajrasky) * Date: 2013-07-17 15:50
In test_http2time_formats test function, they test many type of date & time format, such as:

...
         'Thu, 03 Feb 1994 00:00:00 GMT',  # proposed new HTTP format
         'Thursday, 03-Feb-94 00:00:00 GMT',  # old rfc850 HTTP format
         'Thursday, 03-Feb-1994 00:00:00 GMT',  # broken rfc850 HTTP format

         '03 Feb 1994 00:00:00 GMT',  # HTTP format (no weekday)
...

I think it would be a good idea to add hour-24 to this list. See the patch file.
msg194799 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-08-10 15:09
New changeset ab8da1936297 by Ezio Melotti in branch '3.3':
#18483: add one more date format in test_http2time_formats.  Patch by Vajrasky Kok.
http://hg.python.org/cpython/rev/ab8da1936297

New changeset 5c3708f23351 by Ezio Melotti in branch 'default':
#18483: merge with 3.3.
http://hg.python.org/cpython/rev/5c3708f23351
msg194800 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2013-08-10 15:10
Fixed, thanks for the report and the patch!
History
Date User Action Args
2022-04-11 14:57:48adminsetgithub: 62683
2013-08-10 15:10:45ezio.melottisetstatus: open -> closed

type: enhancement
assignee: ezio.melotti
versions: + Python 3.3
nosy: + ezio.melotti

messages: + msg194800
resolution: fixed
stage: resolved
2013-08-10 15:09:12python-devsetnosy: + python-dev
messages: + msg194799
2013-07-17 15:50:34vajraskycreate