Created on 2013-01-28 17:19 by jkloth, last changed 2013-04-21 14:45 by jkloth. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| test_winreg.diff | jkloth, 2013-01-28 17:19 | review | ||
| Messages (5) | |||
|---|---|---|---|
| msg180863 - (view) | Author: Jeremy Kloth (jkloth) * | Date: 2013-01-28 17:19 | |
test_winreg fails sporadically on the AMD64 Windows buildbot. Looking at the test, it appears that concurrent runs of the test would fail if different processes attempted to modify the test key at the same time. The attached patch resolves this by using a per-process unique test key name using the process ID. |
|||
| msg187502 - (view) | Author: Jeremy Kloth (jkloth) * | Date: 2013-04-21 13:23 | |
Not to sound needy, but could the patch be looked into being integrated soon? This problem had only occurred once or twice a month however it has caused failures three times just in the last week. |
|||
| msg187505 - (view) | Author: Roundup Robot (python-dev) | Date: 2013-04-21 14:14 | |
New changeset 0882960fa6df by R David Murray in branch '3.3': #17065: Use process-unique key for winreg test. http://hg.python.org/cpython/rev/0882960fa6df New changeset c7806d1b09eb by R David Murray in branch 'default': Merge #17065: Use process-unique key for winreg test. http://hg.python.org/cpython/rev/c7806d1b09eb New changeset c0cb78bedc2b by R David Murray in branch '2.7': #17065: Use process-unique key for winreg test. http://hg.python.org/cpython/rev/c0cb78bedc2b |
|||
| msg187506 - (view) | Author: R. David Murray (r.david.murray) *  |
Date: 2013-04-21 14:16 | |
Not being a windows dev I couldn't easily test the patch, so hopefully this commit won't break the buildbots :) |
|||
| msg187507 - (view) | Author: Jeremy Kloth (jkloth) * | Date: 2013-04-21 14:45 | |
Thank you! There are no failures due to the patch and now its just a wait and see if test_winreg will misbehave again. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2013-04-21 14:45:55 | jkloth | set | messages: + msg187507 |
| 2013-04-21 14:16:00 | r.david.murray | set | status: open -> closed versions: - Python 3.2 nosy: + r.david.murray messages: + msg187506 resolution: fixed stage: patch review -> resolved |
| 2013-04-21 14:14:47 | python-dev | set | nosy:
+ python-dev messages: + msg187505 |
| 2013-04-21 13:23:59 | jkloth | set | messages: + msg187502 |
| 2013-01-28 18:43:07 | brian.curtin | set | assignee: brian.curtin |
| 2013-01-28 18:41:17 | serhiy.storchaka | set | versions:
- Python 3.5 nosy: + stutzbach, brian.curtin components: + Windows type: behavior stage: patch review |
| 2013-01-28 17:19:06 | jkloth | create | |