Created on 2012-08-29 01:12 by nbtrap, last changed 2012-12-31 01:32 by lukasz.langa. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| cpython.patch | nbtrap, 2012-08-29 01:12 | Docstring patch | review | |
| Messages (7) | |||
|---|---|---|---|
| msg169324 - (view) | Author: Nathan Trapuzzano (nbtrap) | Date: 2012-08-29 01:12 | |
The docstring on ConfigParser.items() is self-evidently bass ackwards. Fix is in attached patch. |
|||
| msg169381 - (view) | Author: Chris Jerdonek (chris.jerdonek) *  |
Date: 2012-08-29 13:53 | |
This is a nit, but there should be two spaces after the period: + each option in the section. Otherwise, return a list of tuples with |
|||
| msg169383 - (view) | Author: Ezio Melotti (ezio.melotti) * |
Date: 2012-08-29 13:59 | |
While I like to have two spaces after the period, this convenction is not enforced, and it usually depends on the style used in the file. If the double space is used elsewhere in the same document, then it should be preserved, otherwise using a single space is OK too. |
|||
| msg169384 - (view) | Author: Chris Jerdonek (chris.jerdonek) * |
Date: 2012-08-29 14:05 | |
> If the double space is used elsewhere in the same document, You can see one above the change in the patch file. |
|||
| msg169386 - (view) | Author: Nathan Trapuzzano (nbtrap) | Date: 2012-08-29 14:23 | |
Looks like the file has about an equal number of single- and double-spaces after periods. |
|||
| msg178635 - (view) | Author: Roundup Robot (python-dev) | Date: 2012-12-31 01:29 | |
New changeset 850503a117a9 by Łukasz Langa in branch '3.2': Fixes issue #15803: incorrect `ConfigParser.items()` docstring http://hg.python.org/cpython/rev/850503a117a9 New changeset cc277b25eae7 by Łukasz Langa in branch '3.3': Merged fix for #15803 from 3.2 http://hg.python.org/cpython/rev/cc277b25eae7 New changeset b4975cb4be95 by Łukasz Langa in branch 'default': Merged fix for #15803 from 3.2 through 3.3 http://hg.python.org/cpython/rev/b4975cb4be95 |
|||
| msg178636 - (view) | Author: Łukasz Langa (lukasz.langa) |
Date: 2012-12-31 01:31 | |
Patch committed. Thanks for your report, Nathan. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2012-12-31 01:32:10 | lukasz.langa | set | resolution: fixed stage: patch review -> committed/rejected |
| 2012-12-31 01:31:48 | lukasz.langa | set | status: open -> closed messages: + msg178636 |
| 2012-12-31 01:29:42 | python-dev | set | nosy:
+ python-dev messages: + msg178635 |
| 2012-09-11 11:00:46 | lukasz.langa | set | assignee: lukasz.langa |
| 2012-08-29 14:23:07 | nbtrap | set | messages: + msg169386 |
| 2012-08-29 14:05:54 | chris.jerdonek | set | messages: + msg169384 |
| 2012-08-29 13:59:06 | ezio.melotti | set | nosy:
+ ezio.melotti messages: + msg169383 |
| 2012-08-29 13:53:22 | chris.jerdonek | set | nosy:
+ chris.jerdonek messages: + msg169381 |
| 2012-08-29 13:47:17 | r.david.murray | set | type: enhancement -> behavior stage: patch review |
| 2012-08-29 13:47:03 | r.david.murray | set | nosy:
+ lukasz.langa |
| 2012-08-29 01:12:24 | nbtrap | create | |