classification
Title: Avoid nonstandard s6_addr8
Type: compile error Stage: resolved
Components: IO Versions: Python 3.2, Python 3.3, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: phihag, pitrou, python-dev
Priority: normal Keywords: patch

Created on 2012-08-02 15:25 by phihag, last changed 2012-08-02 18:44 by pitrou. This issue is now closed.

Files
File name Uploaded Description Edit
issue15538.patch phihag, 2012-08-02 15:27 Patch to use the standard s6_addr. review
Repositories containing patches
https://bitbucket.org/phihag/cpython
Messages (4)
msg167233 - (view) Author: Philipp Hagemeister (phihag) * Date: 2012-08-02 15:25
The s6_addr8 field of in6_addr structs is nonstandard, and therefore not supported on all platforms (android in my example). cpython's socket module should use the standard s6_addr field instead.
msg167237 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2012-08-02 16:18
Android doesn't have getaddrinfo()? getaddrinfo.c and getnameinfo.c only get compiled when the OS doesn't provide the same-named functions.
msg167246 - (view) Author: Roundup Robot (python-dev) Date: 2012-08-02 18:42
New changeset 86558ff7ce33 by Antoine Pitrou in branch '2.7':
Issue #15538: Fix compilation of the getnameinfo() / getaddrinfo() emulation code.
http://hg.python.org/cpython/rev/86558ff7ce33

New changeset 547f3a55a216 by Antoine Pitrou in branch '3.2':
Issue #15538: Fix compilation of the getnameinfo() / getaddrinfo() emulation code.
http://hg.python.org/cpython/rev/547f3a55a216

New changeset 61a56e982e98 by Antoine Pitrou in branch 'default':
Issue #15538: Fix compilation of the getnameinfo() / getaddrinfo() emulation code.
http://hg.python.org/cpython/rev/61a56e982e98
msg167247 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2012-08-02 18:44
Ok, I couldn't test the patch as getipnodebyname / getipnodebyaddr don't exist here, but I committed it anyway. If it still doesn't work, please re-open the issue.
History
Date User Action Args
2012-08-02 18:44:08pitrousetstatus: open -> closed
versions: - Python 3.4
messages: + msg167247

resolution: fixed
stage: patch review -> resolved
2012-08-02 18:42:17python-devsetnosy: + python-dev
messages: + msg167246
2012-08-02 16:18:18pitrousetnosy: + pitrou

messages: + msg167237
stage: patch review
2012-08-02 15:36:06loewissetversions: - Python 2.6, Python 3.1
2012-08-02 15:27:20phihagsetfiles: + issue15538.patch
keywords: + patch
2012-08-02 15:25:12phihagcreate