This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_sndhdr fails when run from an installation
Type: behavior Stage:
Components: Library (Lib) Versions: Python 3.2, Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: vinay.sajip Nosy List: python-dev, vinay.sajip, vstinner
Priority: normal Keywords: easy, patch

Created on 2012-04-10 13:55 by vinay.sajip, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
Makefile.pre.in.diff vinay.sajip, 2012-04-10 13:55 Patch to Makefile.pre.in to include test/sndhdrdata
Messages (7)
msg157953 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2012-04-10 13:55
test_sndhdr fails when run from an installed Python, due to a missing directory in the installation.

The attached patch should rectify this.
msg157954 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2012-04-10 13:57
Whoops, I think I added Georg when I meant Victor ...
msg157958 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2012-04-10 15:13
Data files were added by the issue #9243 for new tests.
msg157961 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2012-04-10 16:06
> Data files were added by the issue #9243 for new tests.

That's fine, it's just that the Makefile needs to include the new directory test/sndhdrdata (which my patch does). I could have committed the change, but thought you should be in the loop.
msg157964 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2012-04-10 16:14
Python 3.2 should also be fixed. You may need to patch Tools/msi/msi.py in Python 3.2, not in Python 3.3 (see changeset fb7bb61c8847).
msg157970 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2012-04-10 17:44
New changeset b2242224fb7f by Vinay Sajip in branch '3.2':
Issue #14541: Added test/sndhdrdata to Makefile.pre.in for installation.
http://hg.python.org/cpython/rev/b2242224fb7f

New changeset 54bc19fc5b46 by Vinay Sajip in branch 'default':
Issue #14541: Merged addition of test/sndhdrdata to Makefile.pre.in from 3.2.
http://hg.python.org/cpython/rev/54bc19fc5b46
msg157971 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2012-04-10 17:53
Closing, as msi.py for 3.2 appears to already include sndhdrdata.
History
Date User Action Args
2022-04-11 14:57:29adminsetgithub: 58746
2012-04-10 17:53:04vinay.sajipsetstatus: open -> closed
versions: + Python 3.2
messages: + msg157971

assignee: vinay.sajip
resolution: fixed
2012-04-10 17:44:56python-devsetnosy: + python-dev
messages: + msg157970
2012-04-10 16:14:57vstinnersetmessages: + msg157964
2012-04-10 16:06:49vinay.sajipsetmessages: + msg157961
2012-04-10 15:13:10vstinnersetmessages: + msg157958
2012-04-10 13:57:30vinay.sajipsetnosy: + vstinner, - georg.brandl
messages: + msg157954
2012-04-10 13:55:37vinay.sajipcreate