Created on 2012-04-04 17:32 by Claudiu.Popa, last changed 2012-04-05 14:05 by asvetlov. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| idlelib.patch | Claudiu.Popa, 2012-04-04 17:32 | review | ||
| test_tabbedpages.py | Claudiu.Popa, 2012-04-04 18:44 | |||
| Messages (5) | |||
|---|---|---|---|
| msg157494 - (view) | Author: Claudiu Popa (Claudiu.Popa) * | Date: 2012-04-04 17:32 | |
In the file from the subject, page_name was used instead of tab_name, increasing the chances of a NameError exception. I didn't find any tests for IDLE, so there are no tests attached. |
|||
| msg157495 - (view) | Author: Andrew Svetlov (asvetlov) *  |
Date: 2012-04-04 18:07 | |
The patch looks good. Can you describe manual steps to reproduce the issue? |
|||
| msg157497 - (view) | Author: Claudiu Popa (Claudiu.Popa) * | Date: 2012-04-04 18:44 | |
Yes. 1. inherit from TabbedPageSet 2. pass tabs keyword to the internal TabSet instance 3. when the GUI started, enter a page with the same name found in tabs list. NameError will be raised at this point. I'm curios if this script is used anywhere, I couldn't find any reference to it in the source code. |
|||
| msg157590 - (view) | Author: Roundup Robot (python-dev) | Date: 2012-04-05 13:58 | |
New changeset f2dfe0ca6c21 by Andrew Svetlov in branch '3.2': Issue #14496: Fix wrong name in idlelib/tabbedpages.py. http://hg.python.org/cpython/rev/f2dfe0ca6c21 |
|||
| msg157591 - (view) | Author: Andrew Svetlov (asvetlov) * |
Date: 2012-04-05 14:05 | |
Fixed. Thanks. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2012-04-05 14:05:14 | asvetlov | set | status: open -> closed resolution: fixed messages: + msg157591 stage: resolved |
| 2012-04-05 13:58:39 | python-dev | set | nosy:
+ python-dev messages: + msg157590 |
| 2012-04-04 18:44:23 | Claudiu.Popa | set | files:
+ test_tabbedpages.py messages: + msg157497 |
| 2012-04-04 18:07:07 | asvetlov | set | assignee: asvetlov messages: + msg157495 nosy: + asvetlov |
| 2012-04-04 17:32:59 | Claudiu.Popa | create | |