Created on 2007-11-13 19:36 by janssen, last changed 2008-01-06 22:29 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| b.diff | janssen, 2007-11-13 19:36 | Patch | ||
| Messages (6) | |||
|---|---|---|---|
| msg57470 - (view) | Author: Bill Janssen (janssen) *  |
Date: 2007-11-13 19:36 | |
This patch essentially makes GC of sockets work again. See http://mail.python.org/pipermail/python-3000/2007-October/ 011058.html and all the threads in http://mail.python.org/pipermail/ python-3000/2007-October/thread.html with subject line "socket GC worries" for a full discussion. |
|||
| msg57493 - (view) | Author: Guido van Rossum (gvanrossum) * |
Date: 2007-11-14 18:22 | |
Crys, can you test this on Windows and if it does, assign back to me? |
|||
| msg57503 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2007-11-14 19:28 | |
Hi Janssen! The patch at http://bugs.python.org/issue1378 adds suport for _socket.socket.dup() on Windows. It can't dup file descriptors but it can dup socket handlers. Would it make your patch easier? |
|||
| msg57507 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2007-11-14 20:35 | |
I've checked the patch on Windows. I've run the regression tests with -R:: for test_urllib2 test_urllib2net test_urllib test_urllibnet test_socket. The tests are passing and no ref leak shows up. |
|||
| msg57509 - (view) | Author: Guido van Rossum (gvanrossum) * |
Date: 2007-11-14 22:32 | |
Committed revision 58970 (with slight changes). Bill, you can now submit your SSL code for review. |
|||
| msg57518 - (view) | Author: Bill Janssen (janssen) * |
Date: 2007-11-15 02:59 | |
Once I've tried it again. Bill On Nov 14, 2007 2:32 PM, Guido van Rossum <report@bugs.python.org> wrote: > > Guido van Rossum added the comment: > > Committed revision 58970 (with slight changes). > > Bill, you can now submit your SSL code for review. > > ---------- > assignee: gvanrossum -> tiran > resolution: -> accepted > status: open -> closed > > > __________________________________ > Tracker <report@bugs.python.org> > <http://bugs.python.org/issue1439> > __________________________________ > |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2008-01-06 22:29:45 | admin | set | keywords:
- py3k versions: Python 3.0 |
| 2007-11-15 02:59:00 | janssen | set | messages: + msg57518 |
| 2007-11-14 22:32:38 | gvanrossum | set | status: open -> closed assignee: gvanrossum -> christian.heimes resolution: accepted messages: + msg57509 |
| 2007-11-14 20:35:28 | christian.heimes | set | assignee: christian.heimes -> gvanrossum messages: + msg57507 |
| 2007-11-14 19:28:12 | christian.heimes | set | messages: + msg57503 |
| 2007-11-14 18:22:48 | gvanrossum | set | assignee: gvanrossum -> christian.heimes messages: + msg57493 nosy: + christian.heimes |
| 2007-11-13 19:36:37 | janssen | create | |