➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2012-03-19 12:28 by vstinner, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| floattime.patch | vstinner, 2012-03-19 12:28 | review | ||
| Messages (2) | |||
|---|---|---|---|
| msg156334 - (view) | Author: STINNER Victor (vstinner) *  |
Date: 2012-03-19 12:28 | |
floattime() raises an OSError if _PyTime_gettimeofday() returns secs=0 and usec=0. This is wrong because _PyTime_gettimeofday() cannot fail and secs=0 is valid if the current time is 0 (1970.1.1 at 12:00 UTC). Extract of _PyTime_gettimeofday() "doc": /* Similar to POSIX gettimeofday but cannot fail. If system gettimeofday * fails or is not available, fall back to lower resolution clocks. */ PyAPI_FUNC(void) _PyTime_gettimeofday(_PyTime_timeval *tp); In practice, I suppose that nobody noticed the bug because we are in 2012, not in 1969 :-) And even if you change your system clock to 1969.11.31, you may not be able to reproduce the bug because you have to call gettimeofday() exactly at midnight to get also usec=0 ... Attached patch removes the exception. |
|||
| msg156863 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2012-03-26 20:08 | |
New changeset 206c45f45236 by Victor Stinner in branch 'default': Issue #14368: _PyTime_gettimeofday() cannot fail http://hg.python.org/cpython/rev/206c45f45236 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:28 | admin | set | github: 58576 |
| 2012-03-26 20:08:55 | vstinner | set | status: open -> closed resolution: fixed |
| 2012-03-26 20:08:42 | python-dev | set | nosy:
+ python-dev messages: + msg156863 |
| 2012-03-19 12:28:49 | vstinner | create | |