Created on 2011-12-19 16:30 by pitrou, last changed 2012-03-06 05:47 by Arfrever.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| binasciistr.patch | pitrou, 2011-12-20 08:57 | review | ||
| Messages (8) | |||
|---|---|---|---|
| msg149876 - (view) | Author: Antoine Pitrou (pitrou) *  |
Date: 2011-12-19 16:30 | |
a2b_hex and friends accept only byte strings:
>>> binascii.a2b_hex(b'00')
b'\x00'
>>> binascii.a2b_hex('00')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: 'str' does not support the buffer interface
But they could just as well accept ASCII-only unicode strings. Also, with PEP 393, accessing the 8-bit ASCII data doesn't even need a conversion.
|
|||
| msg149905 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2011-12-20 08:57 | |
Here is a patch. |
|||
| msg149911 - (view) | Author: Roundup Robot (python-dev) | Date: 2011-12-20 13:00 | |
New changeset eb8d62706d5f by Antoine Pitrou in branch 'default': Issue #13637: "a2b" functions in the binascii module now accept ASCII-only unicode strings. http://hg.python.org/cpython/rev/eb8d62706d5f |
|||
| msg149913 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2011-12-20 13:08 | |
Committed now. |
|||
| msg153829 - (view) | Author: R. David Murray (r.david.murray) * |
Date: 2012-02-21 01:11 | |
I disagree with this feature. Reopening pending discussion on python-dev. |
|||
| msg154265 - (view) | Author: R. David Murray (r.david.murray) * |
Date: 2012-02-25 15:40 | |
Discussion resolved in favor of patch. |
|||
| msg154964 - (view) | Author: Luke-Jr (luke-jr) | Date: 2012-03-05 17:19 | |
Has this been fixed in 3.2 yet? Somehow it seems to have been "reclassified" as an enhancement when it's really a regression. str worked fine in these functions in 3.1. |
|||
| msg155001 - (view) | Author: Arfrever Frehtes Taifersar Arahesis (Arfrever) | Date: 2012-03-06 05:47 | |
I confirm that it works in Python 3.1 and doesn't work in Python 3.2. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2012-03-06 05:47:37 | Arfrever | set | status: closed -> open type: enhancement -> behavior nosy: + Arfrever messages: + msg155001 resolution: fixed -> stage: committed/rejected -> |
| 2012-03-05 17:19:25 | luke-jr | set | nosy:
+ luke-jr messages: + msg154964 |
| 2012-02-25 15:40:46 | r.david.murray | set | status: open -> closed messages: + msg154265 |
| 2012-02-21 01:11:27 | r.david.murray | set | status: closed -> open nosy: + r.david.murray messages: + msg153829 |
| 2011-12-20 13:09:24 | pitrou | set | status: open -> closed |
| 2011-12-20 13:08:10 | pitrou | set | resolution: fixed messages: + msg149913 stage: patch review -> committed/rejected |
| 2011-12-20 13:00:54 | python-dev | set | nosy:
+ python-dev messages: + msg149911 |
| 2011-12-20 08:57:35 | pitrou | set | files:
+ binasciistr.patch keywords: + patch messages: + msg149905 stage: needs patch -> patch review |
| 2011-12-19 16:30:44 | pitrou | create | |