classification
Title: Document STARTUPINFO and creationflags options for Windows
Type: behavior Stage: resolved
Components: Documentation, Windows Versions: Python 3.3, Python 3.2, Python 3.1, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: brian.curtin Nosy List: brian.curtin, ezio.melotti, python-dev
Priority: normal Keywords: needs review, patch

Created on 2011-04-30 02:16 by brian.curtin, last changed 2011-04-30 03:26 by brian.curtin. This issue is now closed.

Files
File name Uploaded Description Edit
windows_additions.diff brian.curtin, 2011-04-30 02:16 review
Messages (4)
msg134829 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2011-04-30 02:16
Attached is a patch that adds documentation for a few things that have existed in subprocess for a while without documentation.

The "startupinfo" parameter takes subprocess.STARTUPINFO object which takes a few different options for its attributes, but none of this was documented.

The "creationflags" parameter takes subprocess.CREATE_NEW_WINDOW or subprocess.CREATE_NEW_PROCESS_GROUP, but neither were documented as options or what the options mean.
msg134832 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2011-04-30 02:38
You can indent the "attribute" directives and avoid to repeat "STARTUPINFO." before every attribute. If STD_INPUT_HANDLE and the other constants are attributes of STARTUPINFO they should be indented too, otherwise a line that says that subprocess also provides those at module level might be better.
Another short note at the beginning of the section that mentions that this class/attributes are available on Windows only would be good too.
There's also some trailing whitespace that should be removed.
msg134835 - (view) Author: Roundup Robot (python-dev) Date: 2011-04-30 03:24
New changeset 609ca9d71aba by Brian Curtin in branch '3.1':
Fix #11961. Document STARTUPINFO and creation flag options.
http://hg.python.org/cpython/rev/609ca9d71aba

New changeset f0092c611004 by Brian Curtin in branch '3.2':
Fix #11961. Document STARTUPINFO and creation flag options.
http://hg.python.org/cpython/rev/f0092c611004

New changeset f8fae22a1ff0 by Brian Curtin in branch 'default':
Fix #11961. Document STARTUPINFO and creation flag options.
http://hg.python.org/cpython/rev/f8fae22a1ff0

New changeset 9a31422649f1 by Brian Curtin in branch '2.7':
Fix #11961. Document STARTUPINFO and creation flag options.
http://hg.python.org/cpython/rev/9a31422649f1
msg134836 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2011-04-30 03:26
Thanks for having a look, Ezio.
History
Date User Action Args
2011-04-30 03:26:19brian.curtinsetstatus: open -> closed
resolution: fixed
messages: + msg134836

stage: patch review -> resolved
2011-04-30 03:24:37python-devsetnosy: + python-dev
messages: + msg134835
2011-04-30 02:38:44ezio.melottisetnosy: + ezio.melotti
messages: + msg134832
2011-04-30 02:16:44brian.curtincreate