Created on 2011-03-15 18:50 by matiasb, last changed 2011-03-15 19:43 by python-dev. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| add_dis_tests.patch | matiasb, 2011-03-15 18:50 | Updates for test_dis tests | review | |
| updated_add_dis_tests.patch | matiasb, 2011-03-15 19:22 | Updated patch | review | |
| Messages (4) | |||
|---|---|---|---|
| msg131018 - (view) | Author: Matias Bordese (matiasb) * | Date: 2011-03-15 18:50 | |
Attaching patch to add new tests for dis module. |
|||
| msg131021 - (view) | Author: Benjamin Peterson (benjamin.peterson) *  |
Date: 2011-03-15 18:59 | |
1. Use splitlines() instead of split('\n')
2. Use try finally when replacing sys.stdout.
3. Why is dist(None) a RuntimeError and anything else invalid TypeError?
|
|||
| msg131024 - (view) | Author: Matias Bordese (matiasb) * | Date: 2011-03-15 19:22 | |
Updated patch following Benjamin advice (1. and 2.). Re 3. Why is dist(None) a RuntimeError and anything else invalid TypeError? When the dis argument is None, the last traceback is disassembled; if something different to None and that does not have code (ie. no class, method, function or bytecode) is passed, the TypeError exception is raised [0]. [0] http://hg.python.org/cpython/file/1c0cded97280/Lib/dis.py#l28 |
|||
| msg131029 - (view) | Author: Roundup Robot (python-dev) | Date: 2011-03-15 19:43 | |
New changeset f41c3d9e05bd by Benjamin Peterson in branch 'default': improve dis test coverage (closes #11559) http://hg.python.org/cpython/rev/f41c3d9e05bd |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2011-03-15 19:43:45 | python-dev | set | status: open -> closed nosy: + python-dev messages: + msg131029 resolution: fixed stage: committed/rejected |
| 2011-03-15 19:37:17 | ncoghlan | set | nosy:
+ ncoghlan |
| 2011-03-15 19:22:55 | matiasb | set | files:
+ updated_add_dis_tests.patch nosy: benjamin.peterson, matiasb messages: + msg131024 |
| 2011-03-15 18:59:15 | benjamin.peterson | set | nosy:
+ benjamin.peterson messages: + msg131021 |
| 2011-03-15 18:50:26 | matiasb | create | |