classification
Title: test_dummy_thread.py test coverage improvement
Type: behavior Stage: patch review
Components: Tests Versions: Python 3.4, Python 3.3
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: Ramchandra Apte, brett.cannon, brian.curtin, denversc, ezio.melotti, sandro.tosi
Priority: normal Keywords: easy, patch

Created on 2011-03-15 05:31 by denversc, last changed 2013-01-22 12:33 by ezio.melotti.

Files
File name Uploaded Description Edit
test_dummy_thread_test_coverage_improvement.patch denversc, 2011-03-15 05:31 review
test_dummy_thread_test_coverage_improvement_v2.patch denversc, 2011-03-15 05:34 ignore the previous patch; it had an unintentional change to support.py review
Messages (4)
msg130957 - (view) Author: Denver Coneybeare (denversc) * Date: 2011-03-15 05:31
The attached patch increases the test coverage of the module _dummy_thread from 78% to 100%.
msg139070 - (view) Author: Sandro Tosi (sandro.tosi) * (Python committer) Date: 2011-06-25 14:24
I run a review on rietveld, just minor stuff (even though I don't see the 100% coverage).
msg151641 - (view) Author: Sandro Tosi (sandro.tosi) * (Python committer) Date: 2012-01-19 16:18
Hi Denver, do you have the time to address the review on rietveld and propose a new patch?
msg151760 - (view) Author: Denver Coneybeare (denversc) * Date: 2012-01-22 04:29
I've looked at the review (thanks for the review) and can submit an updated patch.  I don't have the Python source code pulled down to my PC anymore so it might take a week or two before I'm able to update the patch and test it out.  I imagine that's not too much of a problem though :)
History
Date User Action Args
2013-01-22 12:33:16ezio.melottisetkeywords: + easy
nosy: + ezio.melotti, Ramchandra Apte
stage: patch review

versions: + Python 3.4
2012-01-22 04:29:28denverscsetmessages: + msg151760
2012-01-19 16:18:35sandro.tosisetmessages: + msg151641
2011-06-25 14:24:00sandro.tosisetnosy: + sandro.tosi
messages: + msg139070
2011-03-15 05:36:49denverscsetnosy: + brett.cannon
2011-03-15 05:34:20denverscsetfiles: + test_dummy_thread_test_coverage_improvement_v2.patch
nosy: brian.curtin, denversc
2011-03-15 05:31:15denversccreate