classification
Title: Add writelines test coverage in tempfile
Type: behavior Stage: committed/rejected
Components: Tests Versions:
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: r.david.murray Nosy List: brian.curtin, ev, ezio.melotti, georg.brandl, python-dev, r.david.murray
Priority: normal Keywords: patch

Created on 2011-03-13 23:08 by ev, last changed 2011-03-14 14:03 by r.david.murray. This issue is now closed.

Files
File name Uploaded Description Edit
test_tempfile_writelines.patch ev, 2011-03-13 23:08 patch against 3.3 review
Messages (5)
msg130778 - (view) Author: Evan Dandrea (ev) * Date: 2011-03-13 23:08
Ran coverage.py and noticed that writelines had no coverage in tempfile, so I added it in.
msg130786 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2011-03-14 03:07
Patch looks good to me.
msg130803 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2011-03-14 12:35
Agreed, looks fine.
msg130814 - (view) Author: Roundup Robot (python-dev) Date: 2011-03-14 14:01
New changeset f816841bab03 by R David Murray in branch '3.1':
#11488: Add tests for writelines method of SpooledTemporaryFile.
http://hg.python.org/cpython/rev/f816841bab03

New changeset da37cc4bd088 by R David Murray in branch '3.2':
Merge #11488 patch from 3.1.
http://hg.python.org/cpython/rev/da37cc4bd088

New changeset 7942f613ea5c by R David Murray in branch 'default':
Merge #11488 patch from 3.2.
http://hg.python.org/cpython/rev/7942f613ea5c

New changeset 7aee0fe6ae5d by R David Murray in branch '2.7':
Port #11488 patch from 3.1 (changeset f816841bab03)
http://hg.python.org/cpython/rev/7aee0fe6ae5d
msg130815 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2011-03-14 14:03
Thanks, Evan.
History
Date User Action Args
2011-03-14 14:03:40r.david.murraysetstatus: open -> closed
nosy: georg.brandl, ezio.melotti, r.david.murray, brian.curtin, python-dev, ev
messages: + msg130815

resolution: accepted
stage: committed/rejected
2011-03-14 14:01:42python-devsetnosy: + python-dev
messages: + msg130814
2011-03-14 12:35:40brian.curtinsetnosy: georg.brandl, ezio.melotti, r.david.murray, brian.curtin, ev
messages: + msg130803
2011-03-14 03:09:17ezio.melottisetnosy: + ezio.melotti
2011-03-14 03:07:22r.david.murraysetassignee: r.david.murray

messages: + msg130786
nosy: + r.david.murray
2011-03-13 23:08:05evcreate