classification
Title: Add support for _msi.Record.GetString() and _msi.Record.GetInteger()
Type: behavior Stage: patch review
Components: Library (Lib), Windows Versions: Python 3.3, Python 3.2, Python 2.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: loewis Nosy List: atuining, loewis, terry.reedy, tim.golden
Priority: high Keywords:

Created on 2007-09-04 21:01 by atuining, last changed 2011-06-12 18:52 by loewis.

Files
File name Uploaded Description Edit
_msi.patch.txt atuining, 2008-10-20 18:47 Patch to fix fetching from views
Messages (6)
msg55644 - (view) Author: Anthony Tuininga (atuining) Date: 2007-09-04 21:06
Attached is a patch that adds the requested support. This is in relation
to the thread at

http://www.gossamer-threads.com/lists/python/python/584264

In addition to the two methods I also "fixed" Fetch() by ensuring that
when the records are exhausted None is returned instead of an error.

If something further is required of me or I submitted this patch
incorrectly, please let me know so I don't screw it up next time. :-)
msg67691 - (view) Author: Anthony Tuininga (atuining) Date: 2008-06-04 13:56
This patch appears to be mostly duplicated by patch 2125 which has been
accepted. Would it be helpful if I separated out the parts that have now
been accepted?
msg67694 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2008-06-04 18:47
Yes, please do provide an updated patch.
msg75000 - (view) Author: Anthony Tuininga (atuining) Date: 2008-10-20 18:47
With apologies for the delay, I have modified the patch to remove the
stuff that has been added already. Some of the other changes are to make
use of new C API functionality but they can be ignored, if desired. The
changes that are relevant are in the view_fetch() routine. Again, if you
have questions, let me know.
msg138211 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2011-06-12 18:46
Martin, would this go in a bugfix release or is it a new feature for 3.3 only?
msg138212 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2011-06-12 18:52
I lost track what problem precisely this patch solves, so it's hard to tell whether it's a bug fix or not.
History
Date User Action Args
2011-06-12 18:52:16loewissetmessages: + msg138212
2011-06-12 18:46:08terry.reedysetnosy: + terry.reedy

messages: + msg138211
versions: + Python 3.3, - Python 3.1
2010-08-16 16:17:20tim.goldensetnosy: + tim.golden
components: + Windows
2010-08-16 16:14:17BreamoreBoysetstage: patch review
type: behavior
versions: + Python 3.1, Python 2.7, Python 3.2, - Python 2.6
2008-10-20 21:33:21loewissetpriority: normal -> high
2008-10-20 18:47:46atuiningsetfiles: + _msi.patch.txt
messages: + msg75000
versions: + Python 2.6, - Python 2.5
2008-10-20 18:45:10atuiningsetfiles: - _msi.patch.txt
2008-06-04 18:47:53loewissetmessages: + msg67694
2008-06-04 13:56:21atuiningsetmessages: + msg67691
2007-09-17 08:08:43jafosetpriority: normal
2007-09-04 21:35:57loewissetassignee: loewis
nosy: + loewis
2007-09-04 21:10:28atuiningsettype: behavior -> (no value)
2007-09-04 21:06:50atuiningsetfiles: + _msi.patch.txt
nosy: + atuining
messages: + msg55644
2007-09-04 21:01:54atuiningcreate