classification
Title: curses for win32
Type: enhancement Stage: patch review
Components: Extension Modules, Windows Versions: Python 3.4
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: BreamoreBoy, akuchling, jlt63, shura_zam, techtonik, tim.golden
Priority: normal Keywords: patch

Created on 2004-08-09 11:05 by shura_zam, last changed 2014-07-09 18:06 by BreamoreBoy.

Files
File name Uploaded Description Edit
_cursesmodule.c.patch shura_zam, 2004-08-09 11:05
test_curses.py.patch shura_zam, 2004-08-09 11:06
mingw32.mak shura_zam, 2004-08-09 11:08 makefile for compile _curses
Messages (15)
msg46600 - (view) Author: Alexandr Zamaraev (shura_zam) Date: 2004-08-09 11:05
I have paths for compile _curses module.
I use 
compiler - mingw32 v3.3.1
curses library - Public Domain Curses (PDCurses 2.6)
msg46601 - (view) Author: A.M. Kuchling (akuchling) * (Python committer) Date: 2005-06-15 19:20
Logged In: YES 
user_id=11375

In the cursesmodule patch, the first argument to intrflush
is changed from NULL to stdscr.  Why?  According to the
ncurses man page, the window argument is ignored.

use_env() is apparently a no-op for PDcurses; why not just
remove the Python-visible use_env function completely? 

In the setting of _C_API_VERSION, what does the string
"PDCurses M" mean?  (In particular, what does the 'M' stand
for?)

Except for the above questions, the patches to
test_curses.py and _cursesmodule.c look OK.  I have no
access to a Windows machine and no way to test them or the
new .mak file, so I'm reassigning this bug to Jason Tishler,
who does a lot of Cygwin work.  Jason, please feel free to
ask me any questions you might have about curses, the
_cursesmodule.c file, or whatever.

msg46602 - (view) Author: Alexandr Zamaraev (shura_zam) Date: 2005-06-16 04:45
Logged In: YES 
user_id=980085

>In the cursesmodule patch, the first argument to intrflush
>is changed from NULL to stdscr.  Why?
In PDCurses intrflush return ERR if first arg is NULL.

>In the setting of _C_API_VERSION, what does the string
>"PDCurses M" mean?  (In particular, what does the 'M' stand
for?)
_C_API_VERSION setting to numeric constant PDC_BUILD
currentli 2601.
Bat _C_API_NAME setting to name of C curses library.
I modyfy source of PDCurses and add suffix "M".
Currently all my changes applay in head branch, 
and suffix "M" not nidded. ;-)
msg46603 - (view) Author: Jason Tishler (jlt63) * Date: 2005-06-16 13:48
Logged In: YES 
user_id=86216

> I have no access to a Windows machine and no way
> to test them or the new .mak file, so I'm
> reassigning this bug to Jason Tishler, who does a
> lot of Cygwin work.  Jason, please feel free to
> ask me any questions you might have about curses,
> the _cursesmodule.c file, or whatever.

Andrew,

Sorry, but I'm confused.  What exactly are you
asking me to do?  Make sure Alexandr's patch
doesn't break the Cygwin build?  Other builds?
Works?

Thanks,
Jason
msg46604 - (view) Author: A.M. Kuchling (akuchling) * (Python committer) Date: 2005-06-16 14:02
Logged In: YES 
user_id=11375

As maintainer of the curses module, applying the patch is OK
with me, but I'm not going to apply it because I don't use
Cygwin, the affected platform.  I leave it up to you to
apply the patch, or reject it, or demand changes; I'm happy
if you decide to apply it, but don't really care.  

(Note that the patch to test_curses.py won't apply cleanly;
it includes some other fixes from Alexandr that I've already
applied.  If you decide to accept the patch, I can help
straighten out test_curses.py.)

msg46605 - (view) Author: Jason Tishler (jlt63) * Date: 2005-06-16 15:28
Logged In: YES 
user_id=86216

If the patch affects Cygwin, then it's not obvious:

$ fgrep -i cygwin _cursesmodule.c.patch mingw32.mak 
test_curses.py.patch
$

However, it seems to affect the native Windows build:

$ grep -i 'platform.*win' _cursesmodule.c.patch mingw32.mak 
test_curses.py.patch 
test_curses.py.patch:+ if sys.platform == 'win32':

Please point out actually where the patch affects Cygwin.
Thanks.
msg46606 - (view) Author: A.M. Kuchling (akuchling) * (Python committer) Date: 2005-06-16 15:34
Logged In: YES 
user_id=11375

Ah; I looked at the initial description which says 'mingw32'
 was used, and thought that was the Cygwin compiler.  Sorry!
 If this patch applies to the standard windows build, just
unassign it; some Windows person will have to look at it.
msg46607 - (view) Author: Jason Tishler (jlt63) * Date: 2005-06-16 17:24
Logged In: YES 
user_id=86216

AFAICT, this patch applies to the standard Windows build.
So, I'm unassigning it as suggested by Andrew.
msg98813 - (view) Author: anatoly techtonik (techtonik) Date: 2010-02-04 07:12
Can this be considered a duplicate of issue 2889?
msg99410 - (view) Author: Jason Tishler (jlt63) * Date: 2010-02-16 14:01
Sorry, but I don't know. I haven't looked at this issue for almost five years! And when I did, I only looked as far to determine it wasn't Cygwin related.
msg114369 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2010-08-19 15:51
Brian or Tim any interest in this?

I consider #2889 to be a duplicate of this and not the other way around.
msg114372 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2010-08-19 16:00
I have zero knowledge and experience when it comes to curses so I'm afraid I can't really provide much here.

One thing I can say is that this patch would have to be converted to be compiled by MSVC rather than MinGW. That was an early issue with #2889 but it appears that patch was converted.
msg114397 - (view) Author: Tim Golden (tim.golden) * (Python committer) Date: 2010-08-19 18:44
It looks as though issue2889 has a better chance of getting into the VS build than this one, which appears to be MingW-based (at a quick glance). I'm loosely keen to see it in, although I have no knowledge of curses as such. I'll assign it to myself so it appears on my to-do queue but I'm not promising to do anything with it immediately. Anyone who feels up to the task, feel free to take it off me.

Mark: why do you consider issue1005895 the master, so to speak? I can see more mileage in pursuing the other?
msg114484 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2010-08-21 11:07
Tim: mainly because this was raised some 4 years earlier and the title of #2889 "curses for windows (alternative patch)"
msg222627 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2014-07-09 18:06
Is this worth pursuing as https://docs.python.org/3/howto/curses.html states "The Windows version of Python doesn’t include the curses module. A ported version called UniCurses is available" ?  This is available at https://pypi.python.org/pypi/UniCurses
History
Date User Action Args
2014-07-09 18:06:01BreamoreBoysetnosy: + BreamoreBoy
messages: + msg222627
2014-02-03 19:08:20BreamoreBoysetnosy: - BreamoreBoy
2012-09-11 22:45:30brian.curtinsetnosy: - brian.curtin
2012-09-11 22:42:41ezio.melottisetversions: + Python 3.4, - Python 3.2
2010-08-21 11:07:49BreamoreBoysetmessages: + msg114484
2010-08-19 18:44:54tim.goldensetmessages: + msg114397
2010-08-19 16:00:34brian.curtinsetmessages: + msg114372
2010-08-19 15:51:01BreamoreBoysetversions: + Python 3.2, - Python 2.7
nosy: + BreamoreBoy, tim.golden, brian.curtin

messages: + msg114369

type: enhancement
stage: patch review
2010-02-16 14:01:52jlt63setmessages: + msg99410
2010-02-04 07:12:56techtoniksetmessages: + msg98813
versions: + Python 2.7, - Python 2.6
2008-05-29 06:00:58techtoniksetnosy: + techtonik
2008-01-04 01:34:41christian.heimessetcomponents: + Windows
versions: + Python 2.6, - Python 2.3
2004-08-09 11:05:57shura_zamcreate