Author mark.dickinson
Recipients facundobatista, jjconti, mark.dickinson, rhettinger, skrah
Date 2010-02-17.16:30:40
SpamBayes Score 4.20924e-12
Marked as misclassified No
Message-id <1266424245.73.0.803241563647.issue7633@psf.upfronthosting.co.za>
In-reply-to
Content
The latest patch looks fine.  I've attached a slightly tweaked version:

 - Add conversions for number_class;  without this, number_class is inconsistent with the various is_*** methods.  "c.is_normal(3)" should be equivalent to "c.number_class(3) in ('+Normal', '-Normal)", for example.

 - Remove conversions for 'canonical' and 'is_canonical';  I agree with Stefan that these don't make a lot of sense.  It's mostly academic, since I can't imagine either of these methods gets much use.

 - I've reworded the documentation slightly.

 - Remove lots of trailing whitespace (mostly on otherwise empty lines).

If this looks okay to everyone, I'll check it in.
History
Date User Action Args
2010-02-17 16:30:46mark.dickinsonsetrecipients: + mark.dickinson, rhettinger, facundobatista, jjconti, skrah
2010-02-17 16:30:45mark.dickinsonsetmessageid: <1266424245.73.0.803241563647.issue7633@psf.upfronthosting.co.za>
2010-02-17 16:30:43mark.dickinsonlinkissue7633 messages
2010-02-17 16:30:43mark.dickinsoncreate