Message98752
In issue7092_test_support:
1) silence_py3k_warning should have a docstring that explain what the function does and what filters should be, possibly including an example;
2) I'd use "if not filters:" instead of "if filters == ():";
3) are there cases where the third arg of filterwarnings is not DeprecationWarning? If not, it's probably better to turn "filters" in a list of regex instead than a sequence of tuples like (regex, DeprecationWarning);
4) maybe silence_py3k_warning could yield an instance of WarningsRecorder, in case someone wants to access the silenced warnings. |
|
Date |
User |
Action |
Args |
2010-02-02 17:55:23 | ezio.melotti | set | recipients:
+ ezio.melotti, barry, rhettinger, amaury.forgeotdarc, pitrou, benjamin.peterson, eric.araujo, brian.curtin, flox, esam |
2010-02-02 17:55:23 | ezio.melotti | set | messageid: <1265133323.22.0.465543689662.issue7092@psf.upfronthosting.co.za> |
2010-02-02 17:55:22 | ezio.melotti | link | issue7092 messages |
2010-02-02 17:55:21 | ezio.melotti | create | |
|