Author r.david.murray
Recipients benjamin.peterson, brian.curtin, cvrebert, georg.brandl, ncoghlan, pitrou, r.david.murray, terry.reedy
Date 2010-02-02.13:30:32
SpamBayes Score 7.75628e-07
Marked as misclassified No
Message-id <1265117434.88.0.497938010243.issue6760@psf.upfronthosting.co.za>
In-reply-to
Content
I like the idea of pointing out that shlex can be used to determine exactly what to pass to subprocess, but I agree that the proposed patch is too wordy (and still too much in a negative voice).

Here is an alternate simpler patch.

Note that while I have also clarified the last sentence in the shell=True case, I think that this is in fact a bug in the Popen API.  As far as I can tell the ability to pass arguments to the shell after the -c is useless, and I think Popen should instead raise a ValueError if passed a sequence when shell is True.  But that is a different bug report....
History
Date User Action Args
2010-02-02 13:30:34r.david.murraysetrecipients: + r.david.murray, georg.brandl, terry.reedy, ncoghlan, pitrou, benjamin.peterson, brian.curtin, cvrebert
2010-02-02 13:30:34r.david.murraysetmessageid: <1265117434.88.0.497938010243.issue6760@psf.upfronthosting.co.za>
2010-02-02 13:30:33r.david.murraylinkissue6760 messages
2010-02-02 13:30:33r.david.murraycreate