Author jaraco
Recipients amaury.forgeotdarc, asvetlov, brian.curtin, eric.smith, ggenellina, giampaolo.rodola, jafo, jaraco, lemburg, loewis, nnorwitz, r.david.murray, ssbarnea, swarren
Date 2010-02-02.12:12:17
SpamBayes Score 0.000590815
Marked as misclassified No
Message-id <D67B8A86984F00488D0776065BA56DBD882237DEED@Teach.jaraco.com>
In-reply-to <1265083603.77.0.330667072003.issue1578269@psf.upfronthosting.co.za>
Content
Brian, thanks for the review. I really appreciate it. I'll fix all of the identified issues.

> Lib/test/test_posixpath.py
> - Lines 365-366 - why check has_symlink() and immediately check it
> again?

In the unpatched code, there were two calls that checked for the existence of 'symlink' in the os module. I thought it strange too, but left it assuming it was there for some reason and not wanting to over extend beyond my primary objective. I will rewrite that test to use only one check unless someone posts otherwise.
History
Date User Action Args
2010-02-02 12:12:20jaracosetrecipients: + jaraco, lemburg, loewis, nnorwitz, jafo, amaury.forgeotdarc, ggenellina, eric.smith, giampaolo.rodola, swarren, r.david.murray, ssbarnea, brian.curtin, asvetlov
2010-02-02 12:12:18jaracolinkissue1578269 messages
2010-02-02 12:12:17jaracocreate